chrome/browser/extensions/webstore_startup_installer_browsertest.cc - Issue 14084002: Disable WebstoreStartupInstallerTest.ArgumentValidation on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

Issue 14084002: Disable WebstoreStartupInstallerTest.ArgumentValidation on windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

diff --git a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

index 6f7fb565ef7e108383eb40ad77bd36d5a5c3c3b8..60635363b8640f30aa27c7398152a9e29e449346 100644

--- a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

+++ b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc

@@ -148,7 +148,8 @@ IN_PROC_BROWSER_TEST_F(WebstoreStartupInstallerTest, FindLink) {

}

// Crashes at random intervals on MacOS: http://crbug.com/95713.

-#if defined(OS_MACOSX)

+// Flakes on Windows: http://crbug.com/229947

+#if defined(OS_MACOSX) || defined(OS_WIN)

#define Maybe_ArgumentValidation DISABLED_ArgumentValidation

#else

#define Maybe_ArgumentValidation ArgumentValidation

« no previous file with comments | « no previous file | no next file » | no next file with comments »