Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: components/guest_view/browser/guest_view_base.cc

Issue 1408393003: Propagate pageScaleFactor to GuestViews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/guest_view/browser/guest_view_base.cc
diff --git a/components/guest_view/browser/guest_view_base.cc b/components/guest_view/browser/guest_view_base.cc
index 063850e6ed8784cf088798f7674298a13ea1bf46..38f41a226115418d8ef026134a0eec5daed78c0b 100644
--- a/components/guest_view/browser/guest_view_base.cc
+++ b/components/guest_view/browser/guest_view_base.cc
@@ -46,7 +46,8 @@ SetSizeParams::~SetSizeParams() {
// This observer ensures that the GuestViewBase destroys itself when its
// embedder goes away. It also tracks when the embedder's fullscreen is
-// toggled so the guest can change itself accordingly.
+// toggled or when its page scale factor changes so the guest can change
+// itself accordingly.
class GuestViewBase::OwnerContentsObserver : public WebContentsObserver {
public:
OwnerContentsObserver(GuestViewBase* guest,
@@ -100,6 +101,13 @@ class GuestViewBase::OwnerContentsObserver : public WebContentsObserver {
}
}
+ void OnPageScaleFactorChanged(float page_scale_factor) override {
+ if (destroyed_)
+ return;
+
+ guest_->web_contents()->SetPageScale(page_scale_factor);
+ }
+
private:
bool is_fullscreen_;
bool destroyed_;

Powered by Google App Engine
This is Rietveld 408576698