Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: content/renderer/render_view_impl.cc

Issue 1408393003: Propagate pageScaleFactor to GuestViews (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Give OnPageScaleFactorChanged suitable behaviour upon navigation Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 489aef6e81f6accbffd4423d5b3269ff10cbb81d..b24a17428af0cbda38291d437a52305a006eecad 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -658,8 +658,7 @@ RenderViewImpl::RenderViewImpl(CompositorDependencies* compositor_deps,
pepper_last_mouse_event_target_(NULL),
#endif
enumeration_completion_id_(0),
- session_storage_namespace_id_(params.session_storage_namespace_id),
- page_scale_factor_is_one_(true) {
+ session_storage_namespace_id_(params.session_storage_namespace_id) {
}
void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,
@@ -1298,7 +1297,8 @@ bool RenderViewImpl::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_SaveImageAt, OnSaveImageAt)
IPC_MESSAGE_HANDLER(ViewMsg_Find, OnFind)
IPC_MESSAGE_HANDLER(ViewMsg_StopFinding, OnStopFinding)
- IPC_MESSAGE_HANDLER(ViewMsg_ResetPageScale, OnResetPageScale)
+ IPC_MESSAGE_HANDLER(ViewMsg_GetPageScale, OnGetPageScale)
+ IPC_MESSAGE_HANDLER(ViewMsg_SetPageScale, OnSetPageScale)
IPC_MESSAGE_HANDLER(ViewMsg_Zoom, OnZoom)
IPC_MESSAGE_HANDLER(ViewMsg_SetZoomLevelForLoadingURL,
OnSetZoomLevelForLoadingURL)
@@ -2456,10 +2456,16 @@ void RenderViewImpl::OnFindMatchRects(int current_version) {
}
#endif
-void RenderViewImpl::OnResetPageScale() {
+void RenderViewImpl::OnGetPageScale() {
+ // Update the browser with the current page scale factor
+ // by sending an extra notification.
+ pageScaleFactorChanged();
+}
+
+void RenderViewImpl::OnSetPageScale(float page_scale_factor) {
if (!webview())
return;
- webview()->setPageScaleFactor(1);
+ webview()->setPageScaleFactor(page_scale_factor);
}
void RenderViewImpl::OnZoom(PageZoom zoom) {
@@ -3372,12 +3378,9 @@ void RenderViewImpl::zoomLevelChanged() {
void RenderViewImpl::pageScaleFactorChanged() {
if (!webview())
return;
- bool page_scale_factor_is_one = webview()->pageScaleFactor() == 1;
- if (page_scale_factor_is_one == page_scale_factor_is_one_)
- return;
- page_scale_factor_is_one_ = page_scale_factor_is_one;
- Send(new ViewHostMsg_PageScaleFactorIsOneChanged(routing_id_,
- page_scale_factor_is_one_));
+
+ Send(new ViewHostMsg_PageScaleFactorChanged(routing_id_,
+ webview()->pageScaleFactor()));
}
double RenderViewImpl::zoomLevelToZoomFactor(double zoom_level) const {
« content/browser/web_contents/web_contents_impl.cc ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698