Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408383007: SkRemote: all paint effects except typeface (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : dont forget patheffect #

Patch Set 3 : ws #

Patch Set 4 : wip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -59 lines) Patch
M src/core/SkRemote.h View 1 2 2 chunks +15 lines, -5 lines 0 comments Download
M src/core/SkRemote.cpp View 1 2 3 10 chunks +158 lines, -54 lines 0 comments Download
M src/core/SkRemote_protocol.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408383007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408383007/60001
5 years, 1 month ago (2015-11-02 16:37:58 UTC) #2
mtklein_C
5 years, 1 month ago (2015-11-02 16:43:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 16:48:59 UTC) #6
hal.canary
lgtm
5 years, 1 month ago (2015-11-02 17:07:31 UTC) #11
hal.canary
lgtm lgtm
5 years, 1 month ago (2015-11-02 17:07:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408383007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408383007/60001
5 years, 1 month ago (2015-11-02 17:07:41 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 17:08:21 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/d1f7e354a140f1a7823145a08c2093d114380564

Powered by Google App Engine
This is Rietveld 408576698