Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408383006: Rename UniverseSelector to DynamicUse and move it to use.dart (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename UniverseSelector to DynamicUse and move it to use.dart BUG= R=sigmund@google.com, sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/419cce7178da16e3967d97e106eb2988717ad253

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -165 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 9 chunks +20 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 28 chunks +40 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 2 chunks +10 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 6 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
Main changes in universe.dart and use.dart
5 years, 1 month ago (2015-11-02 14:20:13 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/universe/use.dart File pkg/compiler/lib/src/universe/use.dart (right): https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/universe/use.dart#newcode5 pkg/compiler/lib/src/universe/use.dart:5: library dart2js.universe.use; Perhaps make a short library dartdoc ...
5 years, 1 month ago (2015-11-02 14:34:56 UTC) #3
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/universe/use.dart File pkg/compiler/lib/src/universe/use.dart (right): https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/universe/use.dart#newcode5 pkg/compiler/lib/src/universe/use.dart:5: library dart2js.universe.use; On 2015/11/02 14:34:56, sigurdm wrote: > ...
5 years, 1 month ago (2015-11-02 16:55:48 UTC) #5
Johnni Winther
Committed patchset #2 (id:20001) manually as 419cce7178da16e3967d97e106eb2988717ad253 (presubmit successful).
5 years, 1 month ago (2015-11-03 09:14:05 UTC) #6
Johnni Winther
5 years, 1 month ago (2015-11-04 10:08:26 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/use.dart (right):

https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/use.dart:5: library dart2js.universe.use;
On 2015/11/02 16:55:47, Siggi Cherem (dart-lang) wrote:
> On 2015/11/02 14:34:56, sigurdm wrote:
> > Perhaps make a short library dartdoc explaining what a "use" is
> 
> +1, let's also add the dartdoc to DynamicUse while we are at it :)

Done.

https://codereview.chromium.org/1408383006/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/use.dart:5: library dart2js.universe.use;
On 2015/11/02 14:34:56, sigurdm wrote:
> Perhaps make a short library dartdoc explaining what a "use" is

Done.

Powered by Google App Engine
This is Rietveld 408576698