Add flag to enable proguard for debug build.

Add flag to enable proguard for debug build.

BUG=544552
Committed: https://crrev.com/cb2b460ee59dd894681c0e8b2240113f715fa588
Cr-Commit-Position: refs/heads/master@{#354891}

[michaelbai, 2015-10-18 00:35:13]

michaelbai@chromium.org changed reviewers:
+ jbudorick@chromium.org

[michaelbai, 2015-10-18 03:47:08]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-18 03:47:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408383002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408383002/1

[commit-bot: I haz the power, 2015-10-18 05:17:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-18 05:17:01]

Dry run: This issue passed the CQ dry run.

[jbudorick, 2015-10-19 13:24:14]

I think there should be a GN equivalent.

https://codereview.chromium.org/1408383002/diff/1/build/java_apk.gypi
File build/java_apk.gypi (right):

https://codereview.chromium.org/1408383002/diff/1/build/java_apk.gypi#newcode96
build/java_apk.gypi:96: 'debug_build_proguard_enabled%': 'false',
I really don't like doing this separately but can understand why it's probably a
better idea to do so.

[Yaron, 2015-10-19 14:42:01]

On 2015/10/19 13:24:14, jbudorick wrote:
> I think there should be a GN equivalent.
> 
> https://codereview.chromium.org/1408383002/diff/1/build/java_apk.gypi
> File build/java_apk.gypi (right):
> 
>
https://codereview.chromium.org/1408383002/diff/1/build/java_apk.gypi#newcode96
> build/java_apk.gypi:96: 'debug_build_proguard_enabled%': 'false',
> I really don't like doing this separately but can understand why it's probably
a
> better idea to do so.

Further: do you really want to do this? From the attached bug it sounds like in
a particular development flow you'll always have to use proguard which makes
incremental compiles painfully slow.

[michaelbai, 2015-10-19 18:23:32]

jbudorick@, as to the gn part, I don't want to add it now because no one uses
it, it will be added in ongoing effect to add gn build in WebView, refer to

https://code.google.com/p/chromium/issues/detail?id=532905
https://codereview.chromium.org/1410203002/

[Yaron, 2015-10-19 18:52:50]

On 2015/10/19 18:23:32, michaelbai wrote:
> jbudorick@, as to the gn part, I don't want to add it now because no one uses
> it, it will be added in ongoing effect to add gn build in WebView, refer to
> 
> https://code.google.com/p/chromium/issues/detail?id=532905
> https://codereview.chromium.org/1410203002/

Michael explained off-thread more about this and that it's more about deployment
and less about active development so I'm not as strongly opposed to it as
before. That said, I worry that it'll affect bot cycle time so would like to see
some measurements on tryjobs before enabling for any targets.

[jbudorick, 2015-10-19 19:52:15]

lgtm w/ nit

https://codereview.chromium.org/1408383002/diff/1/build/android/dex_action.gypi
File build/android/dex_action.gypi (right):

https://codereview.chromium.org/1408383002/diff/1/build/android/dex_action.gy...
build/android/dex_action.gypi:33: 'debug_build_proguard_enabled%': 'false',
nit: Please TODO me to remove this once I've finished multidex.

[michaelbai, 2015-10-19 21:09:57]

https://codereview.chromium.org/1408383002/diff/1/build/android/dex_action.gypi
File build/android/dex_action.gypi (right):

https://codereview.chromium.org/1408383002/diff/1/build/android/dex_action.gy...
build/android/dex_action.gypi:33: 'debug_build_proguard_enabled%': 'false',
On 2015/10/19 19:52:15, jbudorick wrote:
> nit: Please TODO me to remove this once I've finished multidex.

Done.

[michaelbai, 2015-10-19 21:10:04]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-10-19 21:10:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1408383002/#ps20001
(title: "address comment")

[commit-bot: I haz the power, 2015-10-19 21:12:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408383002/20001

[commit-bot: I haz the power, 2015-10-19 22:30:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-19 22:31:01]

Patchset 2 (id:??) landed as
https://crrev.com/cb2b460ee59dd894681c0e8b2240113f715fa588
Cr-Commit-Position: refs/heads/master@{#354891}