Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: content/browser/devtools/protocol/tracing_handler.cc

Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/tracing_handler.cc
diff --git a/content/browser/devtools/protocol/tracing_handler.cc b/content/browser/devtools/protocol/tracing_handler.cc
index 3518ed5e9962112041960417cc7a86f3d03cf37d..601947fd43f551c15973ded63a9fde5e792ffc2e 100644
--- a/content/browser/devtools/protocol/tracing_handler.cc
+++ b/content/browser/devtools/protocol/tracing_handler.cc
@@ -113,7 +113,7 @@ void TracingHandler::OnTraceDataCollected(const std::string& trace_fragment) {
message.reserve(message.size() + trace_fragment.size() + messageSuffixSize);
message += trace_fragment;
message += "] } }";
- client_->SendRawMessage(message);
+ client_->SendRawMessage(0, message);
}
void TracingHandler::OnTraceComplete() {
@@ -152,10 +152,8 @@ Response TracingHandler::Start(DevToolsCommandId command_id,
}
TracingController::GetInstance()->EnableRecording(
- trace_config,
- base::Bind(&TracingHandler::OnRecordingEnabled,
- weak_factory_.GetWeakPtr(),
- command_id));
+ trace_config, base::Bind(&TracingHandler::OnRecordingEnabled,
+ weak_factory_.GetWeakPtr(), command_id));
return Response::OK();
}
@@ -182,8 +180,7 @@ Response TracingHandler::End(DevToolsCommandId command_id) {
Response TracingHandler::GetCategories(DevToolsCommandId command_id) {
TracingController::GetInstance()->GetCategories(
base::Bind(&TracingHandler::OnCategoriesReceived,
- weak_factory_.GetWeakPtr(),
- command_id));
+ weak_factory_.GetWeakPtr(), command_id));
return Response::OK();
}
@@ -207,8 +204,8 @@ void TracingHandler::OnCategoriesReceived(
std::vector<std::string> categories;
for (const std::string& category : category_set)
categories.push_back(category);
- client_->SendGetCategoriesResponse(command_id,
- GetCategoriesResponse::Create()->set_categories(categories));
+ client_->SendGetCategoriesResponse(
+ command_id, GetCategoriesResponse::Create()->set_categories(categories));
}
Response TracingHandler::RequestMemoryDump(DevToolsCommandId command_id) {

Powered by Google App Engine
This is Rietveld 408576698