Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Unified Diff: content/browser/devtools/browser_devtools_agent_host.cc

Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/browser_devtools_agent_host.cc
diff --git a/content/browser/devtools/browser_devtools_agent_host.cc b/content/browser/devtools/browser_devtools_agent_host.cc
index d045571b7377acf45f3d5557a382ecadd23014b2..dd434693670b27865e9b8d0921abf1b4c822e1d5 100644
--- a/content/browser/devtools/browser_devtools_agent_host.cc
+++ b/content/browser/devtools/browser_devtools_agent_host.cc
@@ -30,11 +30,9 @@ BrowserDevToolsAgentHost::BrowserDevToolsAgentHost(
new devtools::tethering::TetheringHandler(socket_callback,
tethering_task_runner)),
tracing_handler_(new devtools::tracing::TracingHandler(
- devtools::tracing::TracingHandler::Browser, GetIOContext())),
- protocol_handler_(new DevToolsProtocolHandler(
- this,
- base::Bind(&BrowserDevToolsAgentHost::SendMessageToClient,
- base::Unretained(this)))) {
+ devtools::tracing::TracingHandler::Browser,
+ GetIOContext())),
dgozman 2015/11/07 02:28:40 Do not touch unnecessary lines.
kozy 2015/11/07 03:02:35 Done.
+ protocol_handler_(new DevToolsProtocolHandler(this, this)) {
DevToolsProtocolDispatcher* dispatcher = protocol_handler_->dispatcher();
dispatcher->SetIOHandler(io_handler_.get());
dispatcher->SetMemoryHandler(memory_handler_.get());
@@ -74,7 +72,7 @@ bool BrowserDevToolsAgentHost::Close() {
bool BrowserDevToolsAgentHost::DispatchProtocolMessage(
const std::string& message) {
- protocol_handler_->HandleMessage(message);
+ protocol_handler_->HandleMessage(session_id(), message);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698