content/renderer/render_view_browsertest.cc - Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/devtools_messages.h ('K') | « content/renderer/devtools/devtools_agent_filter.cc ('k') | content/renderer/service_worker/embedded_worker_devtools_agent.h » ('j') | third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index 3f1250f1827d91ab1f29353b54af4902bd316be6..c9aad544fb56fe7f79aa769dd215f1d95ecb7ce9 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -300,7 +300,7 @@ class DevToolsAgentTest : public RenderViewImplTest {

public:

void Attach() {

std::string host_id = "host_id";

- agent()->OnAttach(host_id);

+ agent()->OnAttach(host_id, 0);

dgozman 2015/11/06 22:57:27 0 -> 17

kozy 2015/11/07 01:54:44 Done.

}

void Detach() {

@@ -312,7 +312,7 @@ class DevToolsAgentTest : public RenderViewImplTest {

}

void DispatchDevToolsMessage(const std::string& message) {

- agent()->OnDispatchOnInspectorBackend(message);

+ agent()->OnDispatchOnInspectorBackend(0, message);

dgozman 2015/11/06 22:57:28 0 -> 17

kozy 2015/11/07 01:54:44 Done.

}

void CloseWhilePaused() {