Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: content/browser/devtools/protocol/tracing_handler.h

Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/tracing_handler.h
diff --git a/content/browser/devtools/protocol/tracing_handler.h b/content/browser/devtools/protocol/tracing_handler.h
index 886067030fd104214e330b4b84e1e4dd9231ad76..c4357732a3db7c42ad0278927ee5e629467ee16d 100644
--- a/content/browser/devtools/protocol/tracing_handler.h
+++ b/content/browser/devtools/protocol/tracing_handler.h
@@ -41,23 +41,26 @@ class TracingHandler {
void OnTraceToStreamComplete(const std::string& stream_handle);
// Protocol methods.
- Response Start(DevToolsCommandId command_id,
+ Response Start(int session_id,
+ DevToolsCommandId command_id,
const std::string* categories,
const std::string* options,
const double* buffer_usage_reporting_interval,
const std::string* transfer_mode);
- Response End(DevToolsCommandId command_id);
- Response GetCategories(DevToolsCommandId command);
- Response RequestMemoryDump(DevToolsCommandId command_id);
+ Response End(int session_id, DevToolsCommandId command_id);
+ Response GetCategories(int session_id, DevToolsCommandId command);
+ Response RequestMemoryDump(int session_id, DevToolsCommandId command_id);
bool did_initiate_recording() { return did_initiate_recording_; }
private:
- void OnRecordingEnabled(DevToolsCommandId command_id);
+ void OnRecordingEnabled(int session_id, DevToolsCommandId command_id);
void OnBufferUsage(float percent_full, size_t approximate_event_count);
- void OnCategoriesReceived(DevToolsCommandId command_id,
+ void OnCategoriesReceived(int session_id,
+ DevToolsCommandId command_id,
const std::set<std::string>& category_set);
- void OnMemoryDumpFinished(DevToolsCommandId command_id,
+ void OnMemoryDumpFinished(int session_id,
+ DevToolsCommandId command_id,
uint64 dump_guid,
bool success);

Powered by Google App Engine
This is Rietveld 408576698