third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py - Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

Issue 1408363004: [DevTools] Filter any messages from previous sessions in DevToolsAgentHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/shared_worker/embedded_shared_worker_stub.cc ('k') | third_party/WebKit/Source/core/inspector/CodeGeneratorInspectorStrings.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

index 446a2ea94ccedb9295e51bbf9a1295c6e52373ee..8a707bccc294323f86158885139f3c0cf9a4c152 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

@@ -1705,7 +1705,7 @@ class Generator:

Generator.method_name_enum_list.append(" %s," % cmd_enum_name)

Generator.method_handler_list.append(" &InspectorBackendDispatcherImpl::%s_%s," % (domain_name, json_command_name))

- Generator.backend_method_declaration_list.append(" void %s_%s(int callId, JSONObject* requestMessageObject, JSONArray* protocolErrors);" % (domain_name, json_command_name))

+ Generator.backend_method_declaration_list.append(" void %s_%s(int sessionId, int callId, JSONObject* requestMessageObject, JSONArray* protocolErrors);" % (domain_name, json_command_name))

backend_agent_interface_list = [] if "redirect" in json_command else Generator.backend_agent_interface_list

@@ -1786,7 +1786,7 @@ class Generator:

callback_writer.newline("class " + callback_name + " : public CallbackBase {\n")

callback_writer.newline("public:\n")

- callback_writer.newline(" " + callback_name + "(PassRefPtrWillBeRawPtr<InspectorBackendDispatcherImpl>, int id);\n")

+ callback_writer.newline(" " + callback_name + "(PassRefPtrWillBeRawPtr<InspectorBackendDispatcherImpl>, int sessionId, int id);\n")

callback_writer.newline(" CORE_EXPORT void sendSuccess(" + ", ".join(decl_parameter_list) + ");\n")

error_part_writer = callback_writer.insert_writer("")

callback_writer.newline("};\n")

@@ -1807,7 +1807,7 @@ class Generator:

ad_hoc_type_output.append(callback_output)

- method_out_code += " RefPtrWillBeRawPtr<" + agent_interface_name + "::" + callback_name + "> callback = adoptRefWillBeNoop(new " + agent_interface_name + "::" + callback_name + "(this, callId));\n"

+ method_out_code += " RefPtrWillBeRawPtr<" + agent_interface_name + "::" + callback_name + "> callback = adoptRefWillBeNoop(new " + agent_interface_name + "::" + callback_name + "(this, sessionId, callId));\n"

agent_call_param_list.append("callback")

normal_response_cook_text += " if (!error.length()) \n"

normal_response_cook_text += " return;\n"