Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1408353009: dart2js cps: Do not propagate InvokeMethodDirectly receiver. (Closed)

Created:
5 years, 1 month ago by asgerf
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Do not propagate InvokeMethodDirectly receiver. The target function might not exist before the class has been instantiated for the first time, so the receiver must be evaluated before the callee expression. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/d730063475ee11d9ee8ff43f20f9053b6d5646e2

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
asgerf
5 years, 1 month ago (2015-11-09 12:51:34 UTC) #2
Kevin Millikin (Google)
LGTM. Instead of this: E.C.prototype.get$positional.call(E.D$()); E.C.prototype.get$named.call(E.D$()); we now get this: var v0 = E.D$(); E.C.prototype.get$positional.call(v0); ...
5 years, 1 month ago (2015-11-09 13:07:14 UTC) #3
asgerf
5 years, 1 month ago (2015-11-09 14:51:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d730063475ee11d9ee8ff43f20f9053b6d5646e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698