Issue 140833003: [Pepper][FileAPI] Interface clean up (3/6)

Issue 140833003: [Pepper][FileAPI] Interface clean up (3/6) (Closed)

Created:
6 years, 11 months ago by tzik

Modified:
6 years, 11 months ago

Reviewers:
bbudge

CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Pepper][FileAPI] Interface clean up * Rename base_file_size to GetEstimatedFileSize * Simplify UpdateMaxWrittenOffset interface BUG=334171 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245490

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix comment #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -48 lines)			Patch
M	content/browser/renderer_host/pepper/quota_reservation.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/quota/open_file_handle.h	View	1	1 chunk	+11 lines, -7 lines	0 comments	Download
M	webkit/browser/fileapi/quota/open_file_handle.cc	View		1 chunk	+5 lines, -9 lines	0 comments	Download
M	webkit/browser/fileapi/quota/open_file_handle_context.h	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	webkit/browser/fileapi/quota/open_file_handle_context.cc	View		2 chunks	+13 lines, -13 lines	0 comments	Download
M	webkit/browser/fileapi/quota/quota_reservation_manager_unittest.cc	View		5 chunks	+13 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tzik

Hi, Bill. This CL should be exactly same to the previous. But, I accidentally pushed ...

6 years, 11 months ago (2014-01-16 13:01:14 UTC) #1

bbudge

LGTM w/nits https://codereview.chromium.org/140833003/diff/1/webkit/browser/fileapi/quota/open_file_handle.h File webkit/browser/fileapi/quota/open_file_handle.h (right): https://codereview.chromium.org/140833003/diff/1/webkit/browser/fileapi/quota/open_file_handle.h#newcode28 webkit/browser/fileapi/quota/open_file_handle.h:28: // QuotaReservation::RefreshQuota and file close. s/file close/and ...

6 years, 11 months ago (2014-01-16 13:47:42 UTC) #2

tzik

https://codereview.chromium.org/140833003/diff/1/webkit/browser/fileapi/quota/open_file_handle.h File webkit/browser/fileapi/quota/open_file_handle.h (right): https://codereview.chromium.org/140833003/diff/1/webkit/browser/fileapi/quota/open_file_handle.h#newcode28 webkit/browser/fileapi/quota/open_file_handle.h:28: // QuotaReservation::RefreshQuota and file close. On 2014/01/16 13:47:42, bbudge ...

6 years, 11 months ago (2014-01-17 04:04:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/140833003/50001

6 years, 11 months ago (2014-01-17 04:04:45 UTC) #4

Message was sent while issue was closed.

Change committed as 245490

Expand Messages | Collapse Messages