Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 14083017: Invalid block doesn't make declaration invalid. (Closed)

Created:
7 years, 10 months ago by SeRya
Modified:
7 years, 10 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Invalid block doesn't make declaration invalid. BUG=140608 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149446

Patch Set 1 : #

Patch Set 2 : Fix #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -46 lines) Patch
M LayoutTests/fast/css/parsing-error-recovery.html View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/core/css/CSSGrammar.y.in View 1 5 chunks +11 lines, -46 lines 10 comments Download

Messages

Total messages: 6 (0 generated)
TabAtkins
The tests look good to me. Again, not familiar enough with our parser to comment ...
7 years, 10 months ago (2013-04-29 17:44:42 UTC) #1
SeRya
I explained in inline comments why I believe this change doesn't break any code where ...
7 years, 10 months ago (2013-04-29 18:01:26 UTC) #2
rune
It certainly looks better with fewer special cases. I have looked through your grammar changes, ...
7 years, 10 months ago (2013-04-30 11:19:14 UTC) #3
apavlov
lgtm The grammar changes look sane given the author's inline comments.
7 years, 10 months ago (2013-04-30 17:00:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/14083017/3001
7 years, 10 months ago (2013-04-30 17:00:15 UTC) #5
commit-bot: I haz the power
7 years, 10 months ago (2013-04-30 18:53:21 UTC) #6
Message was sent while issue was closed.
Change committed as 149446

Powered by Google App Engine
This is Rietveld 408576698