Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: net/quic/quic_crypto_server_stream_test.cc

Issue 14083012: QUIC: retransmit packets with the correct encryption. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_crypto_server_stream_test.cc
diff --git a/net/quic/quic_crypto_server_stream_test.cc b/net/quic/quic_crypto_server_stream_test.cc
index fc58f010dcff25818651af1c409ad044cd361e7d..b81c10e7bef2c57e556fb69b7d43b1feeadb52f1 100644
--- a/net/quic/quic_crypto_server_stream_test.cc
+++ b/net/quic/quic_crypto_server_stream_test.cc
@@ -115,7 +115,8 @@ TEST_F(QuicCryptoServerStreamTest, NotInitiallyConected) {
return;
}
- EXPECT_FALSE(stream_.handshake_complete());
+ EXPECT_FALSE(stream_.encryption_established());
+ EXPECT_FALSE(stream_.handshake_confirmed());
}
TEST_F(QuicCryptoServerStreamTest, ConnectedAfterCHLO) {
@@ -129,8 +130,11 @@ TEST_F(QuicCryptoServerStreamTest, ConnectedAfterCHLO) {
// * One to get a source-address token.
// * One to get the server's certificates
// * One to complete the handshake.
- EXPECT_EQ(3, CompleteCryptoHandshake());
- EXPECT_TRUE(stream_.handshake_complete());
+ // TODO(rtenneti): After ProofVerifier is enabled, change the check for
+ // CompleteCryptoHandshake() from 2 to 3.
wtc 2013/04/25 00:39:19 Could you explain (not in this TODO comment) why t
ramant (doing other things) 2013/04/26 19:29:54 Done.
+ EXPECT_EQ(2, CompleteCryptoHandshake());
+ EXPECT_TRUE(stream_.encryption_established());
+ EXPECT_TRUE(stream_.handshake_confirmed());
}
TEST_F(QuicCryptoServerStreamTest, ZeroRTT) {

Powered by Google App Engine
This is Rietveld 408576698