Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: runtime/bin/vmstats_impl.cc

Issue 14083007: Add new InternetAddress class with a static lookup function (including IPv6 results). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cleanup from review. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmstats_impl.cc
diff --git a/runtime/bin/vmstats_impl.cc b/runtime/bin/vmstats_impl.cc
index d2e0af679d2f5933c7fc81d960170ce9b0e20c4c..2ea94e27261db3d00ce34ad7d6848b19a46e7533 100644
--- a/runtime/bin/vmstats_impl.cc
+++ b/runtime/bin/vmstats_impl.cc
@@ -55,13 +55,14 @@ void VmStats::StartServer(int port, const char* root_dir) {
// TODO(tball): allow host to be specified.
char* host = const_cast<char*>(DEFAULT_HOST);
OSError* os_error;
- const char* host_ip = Socket::LookupIPv4Address(host, &os_error);
- if (host_ip == NULL) {
+ SocketAddresses* addresses = Socket::LookupAddress(host, &os_error);
+ if (addresses == NULL) {
Log::PrintErr("Failed IP lookup of VmStats host %s: %s\n",
host, os_error->message());
return;
}
-
+/*
+ FIXME!
const intptr_t BACKLOG = 128; // Default value from HttpServer.dart
int64_t address = ServerSocket::CreateBindListen(host_ip, port, BACKLOG);
if (address < 0) {
@@ -78,6 +79,7 @@ void VmStats::StartServer(int port, const char* root_dir) {
Log::PrintErr("Failed starting VmStats thread: %d\n", err);
Shutdown();
}
+ */
}
void VmStats::Stop() {

Powered by Google App Engine
This is Rietveld 408576698