Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: test/cctest/compiler/test-run-jscalls.cc

Issue 1408283006: Remove deprecated API usage from compiler cctests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-arguments-inline-3
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-jsbranches.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-jscalls.cc
diff --git a/test/cctest/compiler/test-run-jscalls.cc b/test/cctest/compiler/test-run-jscalls.cc
index a7ceccd3e2aecc03fbefd28feb18e84031ef6b2c..4ee9d8def87131e7cbd9882c065a7ebb831ea1b5 100644
--- a/test/cctest/compiler/test-run-jscalls.cc
+++ b/test/cctest/compiler/test-run-jscalls.cc
@@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// TODO(jochen): Remove this after the setting is turned on globally.
+#define V8_IMMINENT_DEPRECATION_WARNINGS
+
#include "src/v8.h"
#include "test/cctest/compiler/function-tester.h"
@@ -215,7 +218,9 @@ TEST(ContextLoadedFromActivation) {
i::Handle<i::JSFunction> jsfun = Handle<JSFunction>::cast(ofun);
jsfun->set_code(T.function->code());
jsfun->set_shared(T.function->shared());
- context->Global()->Set(v8_str("foo"), v8::Utils::CallableToLocal(jsfun));
+ CHECK(context->Global()
+ ->Set(context, v8_str("foo"), v8::Utils::CallableToLocal(jsfun))
+ .FromJust());
CompileRun("var x = 24;");
ExpectInt32("foo();", 24);
}
@@ -237,7 +242,9 @@ TEST(BuiltinLoadedFromActivation) {
i::Handle<i::JSFunction> jsfun = Handle<JSFunction>::cast(ofun);
jsfun->set_code(T.function->code());
jsfun->set_shared(T.function->shared());
- context->Global()->Set(v8_str("foo"), v8::Utils::CallableToLocal(jsfun));
+ CHECK(context->Global()
+ ->Set(context, v8_str("foo"), v8::Utils::CallableToLocal(jsfun))
+ .FromJust());
CompileRun("var x = 24;");
ExpectObject("foo()", context->Global());
}
« no previous file with comments | « test/cctest/compiler/test-run-jsbranches.cc ('k') | test/cctest/compiler/test-run-jsexceptions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698