Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: test/cctest/compiler/test-run-inlining.cc

Issue 1408283006: Remove deprecated API usage from compiler cctests. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-arguments-inline-3
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/compiler/test-run-deopt.cc ('k') | test/cctest/compiler/test-run-intrinsics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-inlining.cc
diff --git a/test/cctest/compiler/test-run-inlining.cc b/test/cctest/compiler/test-run-inlining.cc
index 05fb6ad46d8f946ad0edc11dac666d85a85ebe1c..49a0029f2c953ce37878f553b6b83f71b08b0598 100644
--- a/test/cctest/compiler/test-run-inlining.cc
+++ b/test/cctest/compiler/test-run-inlining.cc
@@ -2,6 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+// TODO(jochen): Remove this after the setting is turned on globally.
+#define V8_IMMINENT_DEPRECATION_WARNINGS
+
#include "src/v8.h"
#include "src/frames-inl.h"
@@ -30,7 +33,11 @@ void AssertInlineCount(const v8::FunctionCallbackInfo<v8::Value>& args) {
}
List<JSFunction*> functions(2);
topmost->GetFunctions(&functions);
- CHECK_EQ(args[0]->ToInt32(args.GetIsolate())->Value(), functions.length());
+ CHECK_EQ(args[0]
+ ->ToInt32(args.GetIsolate()->GetCurrentContext())
+ .ToLocalChecked()
+ ->Value(),
+ functions.length());
}
@@ -38,7 +45,10 @@ void InstallAssertInlineCountHelper(v8::Isolate* isolate) {
v8::Local<v8::Context> context = isolate->GetCurrentContext();
v8::Local<v8::FunctionTemplate> t =
v8::FunctionTemplate::New(isolate, AssertInlineCount);
- context->Global()->Set(v8_str("AssertInlineCount"), t->GetFunction());
+ CHECK(context->Global()
+ ->Set(context, v8_str("AssertInlineCount"),
+ t->GetFunction(context).ToLocalChecked())
+ .FromJust());
}
« no previous file with comments | « test/cctest/compiler/test-run-deopt.cc ('k') | test/cctest/compiler/test-run-intrinsics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698