build/config/nacl/BUILD.gn - Issue 1408273003: GN: nacl_defines: Drop _BSD_SOURCE, _DEFAULT_SOURCE; conditionalize on OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/nacl/BUILD.gn

Issue 1408273003: GN: nacl_defines: Drop _BSD_SOURCE, _DEFAULT_SOURCE; conditionalize on OS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/nacl/BUILD.gn

diff --git a/build/config/nacl/BUILD.gn b/build/config/nacl/BUILD.gn

index 51ebabd79a385eb7a5b688a7d9e3386a5b632121..f13de4a5f013621a03a7aebee063e58230b3d436 100644

--- a/build/config/nacl/BUILD.gn

+++ b/build/config/nacl/BUILD.gn

@@ -7,11 +7,10 @@ import("//build/config/nacl/config.gni")

# Native Client Definitions

config("nacl_defines") {

defines = [

- "_DEFAULT_SOURCE=1",

- "_BSD_SOURCE=1",

"_POSIX_C_SOURCE=199506",

"_XOPEN_SOURCE=600",

"_GNU_SOURCE=1",

+ "_DARWIN_C_SOURCE=1",

Mark Seaborn 2015/10/20 00:21:00 It seems like some of the reasoning from the commi

"__STDC_LIMIT_MACROS=1",

]

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »