Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: components/arc/arc_bridge_service.cc

Issue 1408263006: chromeos: Add ArcInputBridge to components/arc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@arcxx
Patch Set: fixed scopedfd Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service.cc
diff --git a/components/arc/arc_bridge_service.cc b/components/arc/arc_bridge_service.cc
index 6bd9baeb41ef412be7e15b364478ae439f8c16f5..680288a93f8e9716a071eff4c7e42bc749981c9c 100644
--- a/components/arc/arc_bridge_service.cc
+++ b/components/arc/arc_bridge_service.cc
@@ -125,13 +125,8 @@ void ArcBridgeService::StopInstance() {
bool ArcBridgeService::RegisterInputDevice(const std::string& name,
const std::string& device_type,
base::ScopedFD fd) {
- DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
- if (state_ != State::READY) {
- LOG(ERROR) << "Called RegisterInputDevice when the service is not ready";
- return false;
- }
return ipc_channel_->Send(new ArcInstanceMsg_RegisterInputDevice(
- name, device_type, base::FileDescriptor(fd.Pass())));
+ name, device_type, base::FileDescriptor(fd.release(), true)));
}
void ArcBridgeService::SocketConnect(const base::FilePath& socket_path) {

Powered by Google App Engine
This is Rietveld 408576698