chromeos: Add ArcInputBridge to components/arc

components/arc/arc_bridge_service.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 #define COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_
 
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/sequenced_task_runner.h"
+#include "components/arc/arc_bridge_input_devices.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_listener.h"
 #include "ipc/ipc_message.h"
+#include "ui/events/event.h"
 
 namespace base {
 class CommandLine;
 }
 
 namespace arc {
 
 // The Chrome-side service that handles ARC instances and ARC bridge creation.
 // This service handles the lifetime of ARC instances and sets up the
 // communication channel (the ARC bridge) used to send and receive messages.
@@ skipping 82 matching lines @@
   // class was created on.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Gets the current state of the bridge service.
   State state() const { return state_; }
 
   // Gets if ARC is available in this system.
   bool available() const { return available_; }
 
-  // Requests registration of an input device on the ARC instance.
-  // TODO(denniskempin): Make this interface more typesafe.
-  // |name| should be the displayable name of the emulated device (e.g. "Chrome
-  // OS Keyboard"), |device_type| the name of the device type (e.g. "keyboard")
-  // and |fd| a file descriptor that emulates the kernel events of the device.
-  // This can only be called on the thread that this class was created on.
-  bool RegisterInputDevice(const std::string& name,
-                           const std::string& device_type,
-                           base::ScopedFD fd);
+  // Translates and sends input event to the ARC instance.
+  void SendInputEvent(ui::Event* event);
 
  private:
   friend class ArcBridgeTest;
   FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, Basic);
   FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, ShutdownMidStartup);
 
   // If all pre-requisites are true (ARC is available, it has been enabled, and
   // the session has started), and ARC is stopped, start ARC. If ARC is running
   // and the pre-requisites stop being true, stop ARC.
   void PrerequisitesChanged();
@@ skipping 25 matching lines @@
   void SetState(State state);
 
   // IPC::Listener:
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // DBus callbacks.
   void OnArcAvailable(bool available);
   void OnInstanceStarted(bool success);
   void OnInstanceStopped(bool success);
 
+  // Creates and registers an input device on the ARC instance.
+  // TODO(denniskempin): Make this interface more typesafe.
+  // |name| should be the displayable name of the emulated device (e.g. "Chrome
+  // OS Keyboard"), |device_type| the name of the device type (e.g. "keyboard")
+  // Returns a file descriptor that receives the kernel events of the device.
+  base::ScopedFD CreateBridgeInputDevice(const std::string& name,

[Luis Héctor Chávez, 2015/11/17 17:51:54]

I would prefer if the ArcBridgeService did not have to know about this.

We can discuss the details, but an option is to have the some code in exosphere
that can both listen to events and changes in state of the arc bridge and keep
the RegisterInputDevice interface here?

[denniskempin, 2015/11/19 19:22:09]

done

+                                         const std::string& device_type);
+
+  // Register all bridge input devices with the ARC instance. Called
+  // once the instance is ready.
+  void SetupBridgeInputDevices();
+
+  // List of bridge input devices registered with the ARC instance.
+  ScopedVector<BridgeInputDevice> bridge_devices_;
+
+  // Task runner on which incoming messages are handled.
   scoped_refptr<base::SequencedTaskRunner> origin_task_runner_;
   scoped_refptr<base::SingleThreadTaskRunner> ipc_task_runner_;
   scoped_refptr<base::SequencedTaskRunner> file_task_runner_;
 
   scoped_ptr<IPC::ChannelProxy> ipc_channel_;
 
   base::ObserverList<Observer> observer_list_;
 
   // If the user's session has started.
   bool session_started_;
 
   // If the ARC instance service is available.
   bool available_;
 
   // The current state of the bridge.
   ArcBridgeService::State state_;
 
   // WeakPtrFactory to use callbacks.
   base::WeakPtrFactory<ArcBridgeService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBridgeService);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_BRIDGE_SERVICE_H_