chromeos: Add ArcInputBridge to components/arc

components/arc/arc_bridge_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_bridge_service.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/prefs/pref_registry_simple.h"
@@ skipping 111 matching lines @@
 void ArcBridgeService::AddObserver(Observer* observer) {
   DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
   observer_list_.AddObserver(observer);
 }
 
 void ArcBridgeService::RemoveObserver(Observer* observer) {
   DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
   observer_list_.RemoveObserver(observer);
 }
 
-bool ArcBridgeService::RegisterInputDevice(const std::string& name,
-                                           const std::string& device_type,
-                                           base::ScopedFD fd) {
-  DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
-  if (state_ != State::READY) {
-    LOG(ERROR) << "Called RegisterInputDevice when the service is not ready";
-    return false;
+base::ScopedFD ArcBridgeService::CreateBridgeInputDevice(
+    const std::string& name,
+    const std::string& device_type) {
+  // Create file descriptor pair for communication
+  int fd[2];
+  if (pipe(fd) < 0) {
+    PLOG(ERROR) << "Cannot create pipe";

[Luis Héctor Chávez, 2015/11/17 17:51:53]

At this point the operation cannot continue. return base::ScopedFD()?
Also, HANDLE_EINTR(pipe...)?

[denniskempin, 2015/11/19 19:22:09]

Done.

   }
-  return ipc_channel_->Send(new ArcInstanceMsg_RegisterInputDevice(
-      name, device_type, base::FileDescriptor(fd.Pass())));
+
+  // The read end is sent to the instance
+  ipc_channel_->Send(new ArcInstanceMsg_RegisterInputDevice(

[Luis Héctor Chávez, 2015/11/17 17:51:53]

What if this fails (returns false)? Shouldn't you also return an invalid fd?

[denniskempin, 2015/11/19 19:22:09]

Done. I'm checking for errors and return -1 as a fd. Which is handled as "no
device" by later code.

+      name, device_type, base::FileDescriptor(fd[0], true)));
+
+  // return the write end
+  return base::ScopedFD(fd[1]);
+}
+
+void ArcBridgeService::SetupBridgeInputDevices() {
+  bridge_devices_.push_back(new TouchscreenBridgeInputDevice(
+      CreateBridgeInputDevice("ChromeOS Touchscreen", "touchscreen")));
+  bridge_devices_.push_back(new MouseBridgeInputDevice(
+      CreateBridgeInputDevice("ChromeOS Mouse", "mouse")));
+  bridge_devices_.push_back(new KeyboardBridgeInputDevice(
+      CreateBridgeInputDevice("ChromeOS Keyboard", "keyboard")));
+}
+
+void ArcBridgeService::SendInputEvent(ui::Event* event) {
+  if (bridge_devices_.empty()) {

[denniskempin, 2015/11/16 18:55:49]

NOTE: this is temporary until we have a CL that allows us to hook into boot
states of the instance.

[denniskempin, 2015/11/19 19:22:09]

removed.

+    SetupBridgeInputDevices();
+  }
+  for (BridgeInputDevice* device : bridge_devices_) {
+    device->OnEvent(event);
+  }
 }
 
 void ArcBridgeService::SocketConnect(const base::FilePath& socket_path) {
   DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
   if (state_ != State::STOPPED) {
     VLOG(1) << "SocketConnect() called when instance is not stopped";
     return;
   }
   SetState(State::CONNECTING);
   base::PostTaskAndReplyWithResult(
       file_task_runner_.get(), FROM_HERE,
       base::Bind(&base::CreateDirectory, socket_path.DirName()),
       base::Bind(&ArcBridgeService::SocketConnectAfterEnsureParentDirectory,
                  weak_factory_.GetWeakPtr(), socket_path));
 }
 
 void ArcBridgeService::SocketConnectAfterEnsureParentDirectory(
     const base::FilePath& socket_path,
     bool directory_present) {
   DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
   if (state_ != State::CONNECTING) {
     VLOG(1) << "StopInstance() called while connecting";
     return;
   }
   if (!directory_present) {
     LOG(ERROR) << "Error creating directory for " << socket_path.value();
     StopInstance();
     return;
   }
-
   if (!Connect(IPC::ChannelHandle(socket_path.value()),
                IPC::Channel::MODE_OPEN_NAMED_SERVER)) {
     LOG(ERROR) << "Error connecting to " << socket_path.value();
     StopInstance();
     return;
   }
 
   base::PostTaskAndReplyWithResult(
       file_task_runner_.get(), FROM_HERE,
       // TODO(lhchavez): Tighten the security around the socket by tying it to
@@ skipping 99 matching lines @@
 void ArcBridgeService::OnInstanceStopped(bool success) {
   DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
   // STOPPING is the only valid state for this function.
   // DCHECK on enum classes not supported.
   DCHECK(state_ == State::STOPPING);
   ipc_channel_.reset();
   SetState(State::STOPPED);
 }
 
 }  // namespace arc