Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Side by Side Diff: build/common.gypi

Issue 1408263002: mac: In component builds, link against libc++. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5268 matching lines...) Expand 10 before | Expand all | Expand 10 after
5279 'OTHER_CFLAGS': [ 5279 'OTHER_CFLAGS': [
5280 # Someday this can be replaced by an 'GCC_STRICT_ALIASING': 'NO' 5280 # Someday this can be replaced by an 'GCC_STRICT_ALIASING': 'NO'
5281 # xcode_setting, but not until all downstream projects' mac bots are 5281 # xcode_setting, but not until all downstream projects' mac bots are
5282 # using xcode >= 4.6, because that's when the default value of the 5282 # using xcode >= 4.6, because that's when the default value of the
5283 # flag in the compiler switched. Pre-4.6, the value 'NO' for that 5283 # flag in the compiler switched. Pre-4.6, the value 'NO' for that
5284 # setting is a no-op as far as xcode is concerned, but the compiler 5284 # setting is a no-op as far as xcode is concerned, but the compiler
5285 # behaves differently based on whether -fno-strict-aliasing is 5285 # behaves differently based on whether -fno-strict-aliasing is
5286 # specified or not. 5286 # specified or not.
5287 '-fno-strict-aliasing', # See http://crbug.com/32204. 5287 '-fno-strict-aliasing', # See http://crbug.com/32204.
5288 ], 5288 ],
5289 'conditions': [
5290 ['component=="shared_library"', {
5291 # In component builds, link to the system libc++. This requires
5292 # OS X 10.7, but we currently pass -mmacosx-version-min=10.6.
5293 # Xcode's clang complains about this, but our open-source bundled
5294 # chromium clang doesn't -- it just doesn't implicitly add -lc++
5295 # either. Explicitly add that flag. This has the effect of
5296 # making everything depend on libc++, which means component-build
5297 # binaries won't run on 10.6 (no libc++ there), but for a
5298 # developer-only configuration that's ok.
5299 # (We don't want to raise the deployment target yet so that
5300 # official and dev builds have the same deployment target. This
5301 # affects things like which functions are considered deprecated.)
5302 'CLANG_CXX_LIBRARY': 'libc++', # -stdlib=libc++
5303 'target_conditions': [
5304 ['_type!="static_library"', {
5305 # OTHER_LDFLAGS is passed to both .so and .a links, but only
5306 # the former type understands it. Hence the _type check.
5307 'OTHER_LDFLAGS': [ '-lc++' ],
Mark Mentovai 2015/10/16 22:34:59 I thought CLANG_CXX_LIBRARY would have been enough
Nico 2015/10/16 23:08:35 Excellent question! I thought it wasn't enough bec
5308 }],
5309 ]
5310 }],
5311 ],
5289 }, 5312 },
5290 'target_conditions': [ 5313 'target_conditions': [
5291 ['_type=="executable"', { 5314 ['_type=="executable"', {
5292 'postbuilds': [ 5315 'postbuilds': [
5293 { 5316 {
5294 # Arranges for data (heap) pages to be protected against 5317 # Arranges for data (heap) pages to be protected against
5295 # code execution when running on Mac OS X 10.7 ("Lion"), and 5318 # code execution when running on Mac OS X 10.7 ("Lion"), and
5296 # ensures that the position-independent executable (PIE) bit 5319 # ensures that the position-independent executable (PIE) bit
5297 # is set for ASLR when running on Mac OS X 10.5 ("Leopard"). 5320 # is set for ASLR when running on Mac OS X 10.5 ("Leopard").
5298 'variables': { 5321 'variables': {
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
6297 # settings in target dicts. SYMROOT is a special case, because many other 6320 # settings in target dicts. SYMROOT is a special case, because many other
6298 # Xcode variables depend on it, including variables such as 6321 # Xcode variables depend on it, including variables such as
6299 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6322 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6300 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6323 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6301 # files to appear (when present) in the UI as actual files and not red 6324 # files to appear (when present) in the UI as actual files and not red
6302 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6325 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6303 # and therefore SYMROOT, needs to be set at the project level. 6326 # and therefore SYMROOT, needs to be set at the project level.
6304 'SYMROOT': '<(DEPTH)/xcodebuild', 6327 'SYMROOT': '<(DEPTH)/xcodebuild',
6305 }, 6328 },
6306 } 6329 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698