Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: create_sdk.gyp

Issue 1408253006: Introduce "platform configurations" to replace categories and libraries.dart. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Address review comments. Update create_sdk.gyp, create_sdk.py Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/apiimpl.dart » ('j') | tools/create_sdk.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: create_sdk.gyp
diff --git a/create_sdk.gyp b/create_sdk.gyp
index 769f502e2899672b094b6ce384dca23f47d74344..d647e29ab804a6f98584670ecc7264443a7d08cc 100644
--- a/create_sdk.gyp
+++ b/create_sdk.gyp
@@ -20,13 +20,13 @@
{
'action_name': 'create_sdk_py',
'inputs': [
- # This is neccessary because we have all the pub test files inside
- # the pub directory instead of in tests/pub. Xcode can only handle
- # a certain amount of files in one list (also depending on the
- # length of the path from where you run). This regexp excludes
- # pub/test
+ # Xcode can only handle a certain amount of files in one list
+ # (also depending on the length of the path from where you run).
'<!@(["python", "tools/list_files.py",'
- '"^(?!.*pub/test).*dart$",'
+ '"dart$",'
+ '"sdk/lib"])',
+ '<!@(["python", "tools/list_files.py",'
Bill Hesse 2015/11/02 10:33:27 Would it be better to explicitly list the files he
sigurdm 2015/11/02 11:56:11 Done
+ '"platform$",'
'"sdk/lib"])',
'<!@(["python", "tools/list_files.py", "", '
'"sdk/lib/_internal/js_runtime/lib/preambles"])',
« no previous file with comments | « no previous file | pkg/compiler/lib/src/apiimpl.dart » ('j') | tools/create_sdk.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698