Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408243009: Background tracing: Disable when highres clock is not available (Closed)

Created:
5 years, 1 month ago by oystein (OOO til 10th of July)
Modified:
5 years, 1 month ago
CC:
chromium-reviews, tracing+reviews_chromium.org, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Background tracing: Disable when highres clock is not available R=simonhatch BUG=548756 Committed: https://crrev.com/50d2dfca664cbbab79fe0ddb77ce498d6a8e8638 Cr-Commit-Position: refs/heads/master@{#357160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/tracing/background_tracing_manager_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
shatch
lgtm
5 years, 1 month ago (2015-10-30 14:54:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408243009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408243009/1
5 years, 1 month ago (2015-10-30 14:54:39 UTC) #5
oystein (OOO til 10th of July)
+asvitkine for histograms.xml
5 years, 1 month ago (2015-10-30 18:01:42 UTC) #8
oystein (OOO til 10th of July)
+isherman for histograms.xml, didn't notice asvitkine's (slow) tag, sorry.
5 years, 1 month ago (2015-10-30 18:06:42 UTC) #10
Alexei Svitkine (slow)
lgtm
5 years, 1 month ago (2015-10-30 18:44:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408243009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408243009/1
5 years, 1 month ago (2015-10-30 18:47:07 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 19:00:14 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:00:50 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/50d2dfca664cbbab79fe0ddb77ce498d6a8e8638
Cr-Commit-Position: refs/heads/master@{#357160}

Powered by Google App Engine
This is Rietveld 408576698