Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1408243003: Annotate more functions with _Printf_format_string_ (Closed)

Created:
5 years, 2 months ago by brucedawson
Modified:
5 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, nhiroki, kinuko+fileapi, jshin+watch_chromium.org, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Annotate more functions with _Printf_format_string_ When the stringprintf.h functions were annotated with _Printf_format_string_ there were some other functions that were missed. This time I searched on PRINTF_FORMAT to make sure that all functions annotated with it were annotated for VC++ as well. The definitions and include for _Printf_format_string_ are also now in the proper place in compiler_specific.h. Any bugs that are found by this will show up in the next /analyze report and will be fixed in a follow-on change. Bugs may be hiding in Windows specific code or in code that uses unsupported flags such as %zd. This is a follow on to change 1372153002. BUG=512298, 427616 Committed: https://crrev.com/6a86501038891fd1633901de1edb5e3cd6af9f66 Cr-Commit-Position: refs/heads/master@{#354987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -16 lines) Patch
M base/compiler_specific.h View 2 chunks +4 lines, -0 lines 0 comments Download
M base/strings/string_util.h View 1 chunk +8 lines, -3 lines 0 comments Download
M base/strings/stringprintf.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/logger.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/drive/event_logger.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
brucedawson
This finishes off the previous format-string annotation change. Note that this doesn't fix any bugs ...
5 years, 2 months ago (2015-10-16 22:45:43 UTC) #2
jam
lgtm
5 years, 2 months ago (2015-10-19 20:59:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408243003/1
5 years, 2 months ago (2015-10-20 03:49:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 05:39:07 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 05:40:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a86501038891fd1633901de1edb5e3cd6af9f66
Cr-Commit-Position: refs/heads/master@{#354987}

Powered by Google App Engine
This is Rietveld 408576698