Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: third_party/libaddressinput/chromium/cpp/test/util/json_test.cc

Issue 140823005: [rac] Download country code data in a single HTTP request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/test/util/json_test.cc
diff --git a/third_party/libaddressinput/chromium/cpp/test/util/json_test.cc b/third_party/libaddressinput/chromium/cpp/test/util/json_test.cc
index 3259bfe9ce0bc2bf90ab06b7e6db8d4aae37af22..e68bf56d4252adfbc2f83f31b33c7229096bd5c9 100644
--- a/third_party/libaddressinput/chromium/cpp/test/util/json_test.cc
+++ b/third_party/libaddressinput/chromium/cpp/test/util/json_test.cc
@@ -114,6 +114,33 @@ TEST_F(JsonTest, NumberIsNotValid) {
EXPECT_FALSE(json_->ParseObject("3"));
}
+TEST_F(JsonTest, GetJsonValue) {
+ ASSERT_TRUE(json_->ParseObject("{\"dict\": {\"key\": \"value\"}}"));
+
+ Json* json_value = NULL;
+ ASSERT_TRUE(json_->GetJsonValueForKey("dict", &json_value));
+ scoped_ptr<Json> dict(json_value);
+ ASSERT_TRUE(dict != NULL);
+
+ std::string string_value;
+ EXPECT_TRUE(dict->GetStringValueForKey("key", &string_value));
+ EXPECT_EQ("value", string_value);
+}
+
+TEST_F(JsonTest, GetMissingJsonValue) {
+ ASSERT_TRUE(json_->ParseObject("{\"dict\": {\"key\": \"value\"}}"));
+
+ Json* json_value = NULL;
+ EXPECT_FALSE(json_->GetJsonValueForKey("not-dict", &json_value));
+ EXPECT_TRUE(json_value == NULL);
+}
+
+TEST_F(JsonTest, GetNullJsonValue) {
+ ASSERT_TRUE(json_->ParseObject("{\"dict\": {\"key\": \"value\"}}"));
+ EXPECT_TRUE(json_->GetJsonValueForKey("dict", NULL));
+}
+
+
} // namespace
} // namespace addressinput

Powered by Google App Engine
This is Rietveld 408576698