Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/libaddressinput/chromium/cpp/src/util/json.h

Issue 140823005: [rac] Download country code data in a single HTTP request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comment. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/cpp/src/util/json.h
diff --git a/third_party/libaddressinput/chromium/cpp/src/util/json.h b/third_party/libaddressinput/chromium/cpp/src/util/json.h
index d6405439f76e8af7b9a9d8126811c8d7f9b6d572..ea4f3408020b7a77df2330aedbcfa9811eb50473 100644
--- a/third_party/libaddressinput/chromium/cpp/src/util/json.h
+++ b/third_party/libaddressinput/chromium/cpp/src/util/json.h
@@ -46,6 +46,15 @@ class Json {
virtual bool GetStringValueForKey(const std::string& key,
std::string* value) const = 0;
+ // Sets |value| to the dictionary for |key| if it exists, or false if the key
+ // doesn't exist or doesn't correspond to a dictionary. The JSON object must
+ // be parsed successfully in ParseObject() before invoking this method.
+ //
+ // The old |value| is discarded, but not deleted. The caller owns the
+ // resulting |value|.
+ virtual bool GetJsonValueForKey(const std::string& key,
Evan Stade 2014/01/18 19:14:32 return a scoped_ptr<Json> or if you want to stick
please use gerrit instead 2014/01/21 18:43:54 Great idea! Done.
+ Json** value) const = 0;
+
protected:
Json();
};

Powered by Google App Engine
This is Rietveld 408576698