Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 140823003: Move GrGLExtensions from GrGLContextInfo to GrGLInterface (Closed)

Created:
6 years, 11 months ago by bsalomon
Modified:
6 years, 11 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move GrGLExtensions from GrGLContextInfo to GrGLInterface BUG=skia:2042 Committed: http://code.google.com/p/skia/source/detail?r=13118

Patch Set 1 #

Patch Set 2 : upload again, rietveld diff failed. #

Total comments: 4

Patch Set 3 : rebase #

Patch Set 4 : Rob's comment #

Patch Set 5 : Bring to ToT and fix linux build #

Patch Set 6 : tot #

Patch Set 7 : tot - save file this time #

Patch Set 8 : Fix Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -93 lines) Patch
M include/core/SkTemplates.h View 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLExtensions.h View 1 2 3 4 2 chunks +15 lines, -9 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 2 3 4 1 chunk +18 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 4 5 2 chunks +15 lines, -17 lines 0 comments Download
M include/gpu/gl/SkGLContextHelper.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLContext.h View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M src/gpu/gl/GrGLExtensions.cpp View 4 chunks +14 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 4 5 6 12 chunks +30 lines, -26 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 4 5 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/SkGLContextHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 2 3 4 5 6 7 3 chunks +13 lines, -8 lines 0 comments Download
M src/gpu/gl/iOS/GrGLCreateNativeInterface_iOS.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/mesa/GrGLCreateMesaInterface.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
6 years, 11 months ago (2014-01-16 16:38:54 UTC) #1
robertphillips
lgtm (modulo trybot failures) + 2 questions https://codereview.chromium.org/140823003/diff/190001/include/gpu/gl/GrGLExtensions.h File include/gpu/gl/GrGLExtensions.h (right): https://codereview.chromium.org/140823003/diff/190001/include/gpu/gl/GrGLExtensions.h#newcode23 include/gpu/gl/GrGLExtensions.h:23: public: delete ...
6 years, 11 months ago (2014-01-16 17:13:11 UTC) #2
bsalomon
https://codereview.chromium.org/140823003/diff/190001/include/gpu/gl/GrGLExtensions.h File include/gpu/gl/GrGLExtensions.h (right): https://codereview.chromium.org/140823003/diff/190001/include/gpu/gl/GrGLExtensions.h#newcode23 include/gpu/gl/GrGLExtensions.h:23: public: On 2014/01/16 17:13:11, robertphillips wrote: > delete this? ...
6 years, 11 months ago (2014-01-16 18:28:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/140823003/450001
6 years, 11 months ago (2014-01-17 14:53:48 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 15:05:45 UTC) #5
Message was sent while issue was closed. 
Change committed as 13118

Powered by Google App Engine
This is Rietveld 408576698