Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 140823002: Enable building with configuration_policy==1 on ios. (Closed)

Created:
6 years, 11 months ago by Joao da Silva
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enable building with configuration_policy==1 on ios. BUG=275292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -20 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/components.gyp View 3 chunks +2 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M components/policy.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/policy_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/policy_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/policy_common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
These changes make building with configuration_policy==1 possible on ios. Note that configuration_policy is still set ...
6 years, 11 months ago (2014-01-16 12:49:45 UTC) #1
dconnelly
lgtm
6 years, 11 months ago (2014-01-17 08:57:52 UTC) #2
Joao da Silva
@Jochen: ping :-)
6 years, 11 months ago (2014-01-17 09:35:53 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-17 12:25:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/140823002/1
6 years, 11 months ago (2014-01-17 13:24:13 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 14:55:43 UTC) #6
Message was sent while issue was closed.
Change committed as 245521

Powered by Google App Engine
This is Rietveld 408576698