Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1408223009: VM: Change debug printing of Context to not print the raw-pointer (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Change debug printing of Context to not print the raw-pointer This makes comparing flow-graphs from different runs of the VM much easier. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/94e5994f16def4706ca36c6a6105f514798d7aac

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/vm/object.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Florian Schneider
5 years, 1 month ago (2015-10-30 17:41:56 UTC) #2
rmacnak
lgtm w/ nit https://codereview.chromium.org/1408223009/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1408223009/diff/1/runtime/vm/object.cc#newcode13881 runtime/vm/object.cc:13881: return zone->PrintToString("Context num_variables:% " Pd "", ...
5 years, 1 month ago (2015-10-30 18:13:04 UTC) #3
Florian Schneider
Committed patchset #2 (id:20001) manually as 94e5994f16def4706ca36c6a6105f514798d7aac (presubmit successful).
5 years, 1 month ago (2015-10-30 18:19:44 UTC) #4
Florian Schneider
https://codereview.chromium.org/1408223009/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1408223009/diff/1/runtime/vm/object.cc#newcode13881 runtime/vm/object.cc:13881: return zone->PrintToString("Context num_variables:% " Pd "", On 2015/10/30 18:13:04, ...
5 years, 1 month ago (2015-10-30 18:26:09 UTC) #5
Florian Schneider
5 years, 1 month ago (2015-10-30 18:26:09 UTC) #6
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698