Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1408223008: [MD] Share button code between find bar and download shelf (Closed)

Created:
5 years, 1 month ago by Evan Stade
Modified:
5 years, 1 month ago
Reviewers:
sky, Hadi
CC:
chromium-reviews, asanka, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Share button code between find bar and download shelf - improved theme support in both find bar and download shelf - inkdrop effect in download shelf - less code duplication Looks better on inverted color schemes on Windows or Linux (with GTK theming on). Should have no effect on CrOS because the browser theme doesn't change these colors and there's only one native theme. BUG=512443 Committed: https://crrev.com/1028d4b5822ef0db26d626d00e85b6b8233fb41f Cr-Commit-Position: refs/heads/master@{#357696}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : one more place #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -220 lines) Patch
A chrome/browser/ui/views/bar_control_button.h View 1 2 1 chunk +56 lines, -0 lines 2 comments Download
A chrome/browser/ui/views/bar_control_button.cc View 1 2 1 chunk +137 lines, -0 lines 8 comments Download
M chrome/browser/ui/views/download/download_item_view_md.h View 1 2 5 chunks +15 lines, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 2 9 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 2 7 chunks +19 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 2 10 chunks +48 lines, -173 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Evan Stade
5 years, 1 month ago (2015-11-03 21:48:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408223008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408223008/40001
5 years, 1 month ago (2015-11-03 21:49:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 23:19:25 UTC) #7
sky
https://codereview.chromium.org/1408223008/diff/40001/chrome/browser/ui/views/bar_control_button.cc File chrome/browser/ui/views/bar_control_button.cc (right): https://codereview.chromium.org/1408223008/diff/40001/chrome/browser/ui/views/bar_control_button.cc#newcode30 chrome/browser/ui/views/bar_control_button.cc:30: const int kInkDropSmallCornerRadius = 2; Are these constants really ...
5 years, 1 month ago (2015-11-03 23:46:43 UTC) #8
Evan Stade
+moshayedi for inkdrop related questions https://codereview.chromium.org/1408223008/diff/40001/chrome/browser/ui/views/bar_control_button.cc File chrome/browser/ui/views/bar_control_button.cc (right): https://codereview.chromium.org/1408223008/diff/40001/chrome/browser/ui/views/bar_control_button.cc#newcode30 chrome/browser/ui/views/bar_control_button.cc:30: const int kInkDropSmallCornerRadius = ...
5 years, 1 month ago (2015-11-03 23:51:17 UTC) #10
sky
Ok, LGTM
5 years, 1 month ago (2015-11-04 00:36:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408223008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408223008/40001
5 years, 1 month ago (2015-11-04 00:48:38 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-04 01:12:30 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 01:13:36 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1028d4b5822ef0db26d626d00e85b6b8233fb41f
Cr-Commit-Position: refs/heads/master@{#357696}

Powered by Google App Engine
This is Rietveld 408576698