Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1408223004: Expose string/regexp related public symbols on harmony flag. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose string/regexp related public symbols on harmony flag. R=littledan@chromium.org BUG=v8:4305, v8:4343, v8:4344, v8:4345 LOG=N Committed: https://crrev.com/f8a43459d4ee65ec2c9afc4aa8bc9746f9cc6c0b Cr-Commit-Position: refs/heads/master@{#31702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -53 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 4 chunks +44 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download
D src/js/harmony-concat-spreadable.js View 1 chunk +0 lines, -19 lines 0 comments Download
D src/js/harmony-tostring.js View 1 chunk +0 lines, -19 lines 0 comments Download
M src/js/symbol.js View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yang
5 years, 1 month ago (2015-10-29 12:52:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408223004/1
5 years, 1 month ago (2015-10-29 12:52:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 13:52:52 UTC) #5
Yang
On 2015/10/29 13:52:52, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 1 month ago (2015-10-30 05:54:56 UTC) #6
Yang
Michael, could you take a look at this CL? Thanks!
5 years, 1 month ago (2015-11-02 05:34:01 UTC) #8
Yang
Nevermind Michael... Igor, could you take a look? Thanks.
5 years, 1 month ago (2015-11-02 05:38:27 UTC) #10
Igor Sheludko
lgtm
5 years, 1 month ago (2015-11-02 07:44:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408223004/1
5 years, 1 month ago (2015-11-02 07:52:41 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-02 08:42:49 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 08:43:10 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8a43459d4ee65ec2c9afc4aa8bc9746f9cc6c0b
Cr-Commit-Position: refs/heads/master@{#31702}

Powered by Google App Engine
This is Rietveld 408576698