Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408213008: Add test for CPDF_StreamParser::ReadHexString. (Closed)

Created:
5 years, 1 month ago by dsinclair
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test for CPDF_StreamParser::ReadHexString. This CL adds a unit test for the ReadHexString method. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c89c6195373b63e99b9cd432c5a181bfb3ad8dbe

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A core/src/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp View 1 chunk +48 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dsinclair
PTAL.
5 years, 1 month ago (2015-11-02 19:47:12 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1408213008/diff/1/core/src/fpdfapi/fpdf_page/pageint.h File core/src/fpdfapi/fpdf_page/pageint.h (right): https://codereview.chromium.org/1408213008/diff/1/core/src/fpdfapi/fpdf_page/pageint.h#newcode14 core/src/fpdfapi/fpdf_page/pageint.h:14: #include "../../../include/fpdfapi/fpdf_page.h" nit: alphabetize.
5 years, 1 month ago (2015-11-02 20:59:22 UTC) #3
dsinclair
https://codereview.chromium.org/1408213008/diff/1/core/src/fpdfapi/fpdf_page/pageint.h File core/src/fpdfapi/fpdf_page/pageint.h (right): https://codereview.chromium.org/1408213008/diff/1/core/src/fpdfapi/fpdf_page/pageint.h#newcode14 core/src/fpdfapi/fpdf_page/pageint.h:14: #include "../../../include/fpdfapi/fpdf_page.h" On 2015/11/02 20:59:22, Tom Sepez wrote: > ...
5 years, 1 month ago (2015-11-02 21:35:03 UTC) #4
dsinclair
5 years, 1 month ago (2015-11-02 21:35:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c89c6195373b63e99b9cd432c5a181bfb3ad8dbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698