Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1408213005: Remove SkThread::setProcessorAffinity() (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkThread::setProcessorAffinity() It's only used by a couple unit tests. We have other ways of getting the same quality testing of our ref-count code now (e.g. TSAN). BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/a1bde7d2e152188f8d5a2d0f759030ed032a2522

Patch Set 1 #

Patch Set 2 : gAdds #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -167 lines) Patch
M BUILD.public View 1 chunk +0 lines, -2 lines 0 comments Download
M cmake/CMakeLists.txt View 2 chunks +1 line, -4 lines 0 comments Download
M gyp/utils.gyp View 3 chunks +0 lines, -11 lines 0 comments Download
M gyp/utils.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M src/utils/SkThreadUtils.h View 1 chunk +0 lines, -7 lines 0 comments Download
D src/utils/SkThreadUtils_pthread_linux.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D src/utils/SkThreadUtils_pthread_mach.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
D src/utils/SkThreadUtils_pthread_other.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/utils/SkThreadUtils_win.cpp View 2 chunks +1 line, -39 lines 0 comments Download
M tests/AtomicTest.cpp View 1 2 chunks +3 lines, -5 lines 0 comments Download
M tests/RefCntTest.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213005/1
5 years, 2 months ago (2015-10-20 16:42:29 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3709) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years, 2 months ago (2015-10-20 16:43:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213005/20001
5 years, 2 months ago (2015-10-20 16:43:47 UTC) #6
mtklein_C
5 years, 2 months ago (2015-10-20 16:45:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 16:53:40 UTC) #10
bungeman-skia
tsan and valgrind for the win! lgtm
5 years, 2 months ago (2015-10-20 18:03:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213005/20001
5 years, 2 months ago (2015-10-20 18:04:28 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 18:05:09 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a1bde7d2e152188f8d5a2d0f759030ed032a2522

Powered by Google App Engine
This is Rietveld 408576698