Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 1408213004: Refactor array construction for map, filter (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
yangguo, adamk, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor array construction for map, filter This patch refactors array methods to have the InnerArray{Map,Filter} methods convert to a GlobalArray rather than the callers. BUG=chromium:544991 R=yangguo,adamk CC=mstarzinger,jochen LOG=Y Committed: https://crrev.com/c227dd5734efa41e4973c834c910bb684a9e1998 Cr-Commit-Position: refs/heads/master@{#31403}

Patch Set 1 #

Patch Set 2 : Added a test #

Total comments: 1

Patch Set 3 : Test improvement #

Patch Set 4 : Test improvement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M src/js/array.js View 4 chunks +8 lines, -10 lines 0 comments Download
A test/mjsunit/regress/regress-544991.js View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
Dan Ehrenberg
5 years, 2 months ago (2015-10-20 08:32:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213004/1
5 years, 2 months ago (2015-10-20 08:33:06 UTC) #3
adamk
lgtm once you have a test
5 years, 2 months ago (2015-10-20 09:00:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 09:01:22 UTC) #6
Yang
On 2015/10/20 09:01:22, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-10-20 09:07:03 UTC) #7
Dan Ehrenberg
On 2015/10/20 at 09:07:03, yangguo wrote: > On 2015/10/20 09:01:22, commit-bot: I haz the power ...
5 years, 2 months ago (2015-10-20 09:21:28 UTC) #8
Yang
On 2015/10/20 09:21:28, Dan Ehrenberg wrote: > On 2015/10/20 at 09:07:03, yangguo wrote: > > ...
5 years, 2 months ago (2015-10-20 09:26:20 UTC) #9
adamk
I'd suggest leaving out the "if (called)" (see below), other than the lgtm, thanks https://codereview.chromium.org/1408213004/diff/20001/test/mjsunit/regress/regress-544991.js ...
5 years, 2 months ago (2015-10-20 09:28:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213004/20001
5 years, 2 months ago (2015-10-20 09:31:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408213004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408213004/60001
5 years, 2 months ago (2015-10-20 09:33:43 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-20 09:57:04 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 09:57:17 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c227dd5734efa41e4973c834c910bb684a9e1998
Cr-Commit-Position: refs/heads/master@{#31403}

Powered by Google App Engine
This is Rietveld 408576698