Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

Issue 1408203003: Disable insertion points in v1 shadow trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v1-youngest-shadow-root-ref
Patch Set: remove expectations Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 private: 74 private:
75 ElementShadow(); 75 ElementShadow();
76 76
77 #if !ENABLE(OILPAN) 77 #if !ENABLE(OILPAN)
78 void removeDetachedShadowRoots(); 78 void removeDetachedShadowRoots();
79 #endif 79 #endif
80 80
81 void distribute(); 81 void distribute();
82 void clearDistribution(); 82 void clearDistribution();
83 83
84 void distributeV0();
85 void distributeV1();
kochi 2015/10/21 03:13:51 Do we use "V1" in the source code? I guess V0 is o
86
84 void collectSelectFeatureSetFrom(ShadowRoot&); 87 void collectSelectFeatureSetFrom(ShadowRoot&);
85 void distributeNodeChildrenTo(InsertionPoint*, ContainerNode*); 88 void distributeNodeChildrenTo(InsertionPoint*, ContainerNode*);
86 89
87 bool needsSelectFeatureSet() const { return m_needsSelectFeatureSet; } 90 bool needsSelectFeatureSet() const { return m_needsSelectFeatureSet; }
88 void setNeedsSelectFeatureSet() { m_needsSelectFeatureSet = true; } 91 void setNeedsSelectFeatureSet() { m_needsSelectFeatureSet = true; }
89 92
93 bool isV1() const { return youngestShadowRoot().type() == ShadowRootType::Op en || youngestShadowRoot().type() == ShadowRootType::Closed; };
94
90 #if ENABLE(OILPAN) 95 #if ENABLE(OILPAN)
91 // The cost of |new| in Oilpan is lower than non-Oilpan. We should reduce 96 // The cost of |new| in Oilpan is lower than non-Oilpan. We should reduce
92 // the size of HashMap entry. 97 // the size of HashMap entry.
93 typedef HeapHashMap<Member<const Node>, Member<DestinationInsertionPoints>> NodeToDestinationInsertionPoints; 98 typedef HeapHashMap<Member<const Node>, Member<DestinationInsertionPoints>> NodeToDestinationInsertionPoints;
94 #else 99 #else
95 typedef HashMap<const Node*, DestinationInsertionPoints> NodeToDestinationIn sertionPoints; 100 typedef HashMap<const Node*, DestinationInsertionPoints> NodeToDestinationIn sertionPoints;
96 #endif 101 #endif
97 NodeToDestinationInsertionPoints m_nodeToInsertionPoints; 102 NodeToDestinationInsertionPoints m_nodeToInsertionPoints;
98 103
99 SelectRuleFeatureSet m_selectFeatures; 104 SelectRuleFeatureSet m_selectFeatures;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 inline void ElementShadow::distributeIfNeeded() 138 inline void ElementShadow::distributeIfNeeded()
134 { 139 {
135 if (m_needsDistributionRecalc) 140 if (m_needsDistributionRecalc)
136 distribute(); 141 distribute();
137 m_needsDistributionRecalc = false; 142 m_needsDistributionRecalc = false;
138 } 143 }
139 144
140 } // namespace 145 } // namespace
141 146
142 #endif 147 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698