Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1408193009: dart2js cps_ir: propagate constant field values (Closed)

Created:
5 years, 1 month ago by sra1
Modified:
5 years, 1 month ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps_ir: propagate constant field values The effect is to remove endianness logic in SHA1. Mark some single-call methods as @NoInline() R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/7b48eb2b7fbcf6b7ee40372e31addec64d4c8d8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_helper.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
5 years, 1 month ago (2015-11-05 03:32:52 UTC) #2
asgerf
lgtm
5 years, 1 month ago (2015-11-05 11:17:22 UTC) #3
sra1
5 years, 1 month ago (2015-11-05 18:40:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b48eb2b7fbcf6b7ee40372e31addec64d4c8d8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698