Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1408193006: [turbofan] Deprecate RawMachineAssembler::CallFunctionStub0. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Deprecate RawMachineAssembler::CallFunctionStub0. This deprecates the ability of the raw machine assembler to utilize the CallFunctionStub in preparation of the stub itself being deprecated. We only used this to test instruction selection of calls to stubs that can deoptimize, the test has been adapted. R=verwaest@chromium.org TEST=unittests/InstructionSelectorTest Committed: https://crrev.com/e3f4047814423001d0f3d226b3624c76d1eab7b8 Cr-Commit-Position: refs/heads/master@{#31799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -32 lines) Patch
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 8 chunks +27 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-04 16:33:30 UTC) #1
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-04 16:52:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408193006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408193006/1
5 years, 1 month ago (2015-11-04 17:15:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 17:17:12 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 17:17:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f4047814423001d0f3d226b3624c76d1eab7b8
Cr-Commit-Position: refs/heads/master@{#31799}

Powered by Google App Engine
This is Rietveld 408576698