Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8962)

Unified Diff: chrome/browser/ui/chrome_bubble_manager.cc

Issue 1408193003: Add chrome side webusb permission UI code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address sky@'s comments, added TODO to chrome_bubble_manager.cc Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/chrome_bubble_manager.cc
diff --git a/chrome/browser/ui/chrome_bubble_manager.cc b/chrome/browser/ui/chrome_bubble_manager.cc
index 33890dcaac7b05f5ec654697313cbff70c47e6ef..56b686e10ca1619044bdd2c77c79b9b5bf4a104c 100644
--- a/chrome/browser/ui/chrome_bubble_manager.cc
+++ b/chrome/browser/ui/chrome_bubble_manager.cc
@@ -31,11 +31,15 @@ enum BubbleType {
// Permissions-related bubbles:
BUBBLE_TYPE_PERMISSION = 30, // Displays a permission request to the user.
+ BUBBLE_TYPE_CHOOSER_PERMISSION = 31, // For chooser permissions.
// Upper boundary for metrics.
BUBBLE_TYPE_MAX,
};
+// TODO(juncai): Since LogBubbleCloseReason function adds metrics for each
+// close type, we can use only enum, and it may not be necessary to keep the
+// bubble name.
// Convert from bubble name to ID. The bubble ID will allow collecting the
// close reason for each bubble type.
static int GetBubbleId(BubbleReference bubble) {
@@ -50,6 +54,8 @@ static int GetBubbleId(BubbleReference bubble) {
bubble_type = BUBBLE_TYPE_TRANSLATE;
else if (bubble->GetName().compare("PermissionBubble") == 0)
bubble_type = BUBBLE_TYPE_PERMISSION;
+ else if (bubble->GetName().compare("ChooserBubble") == 0)
+ bubble_type = BUBBLE_TYPE_CHOOSER_PERMISSION;
DCHECK_NE(bubble_type, BUBBLE_TYPE_UNKNOWN);
DCHECK_NE(bubble_type, BUBBLE_TYPE_MAX);
« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698