Add chrome side webusb permission UI code

chrome/browser/ui/chrome_bubble_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/chrome_bubble_manager.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "components/bubble/bubble_controller.h"
@@ skipping 13 matching lines @@
   BUBBLE_TYPE_MOCK = 1,     // Used for testing.
 
   // Extension-related bubbles:
   BUBBLE_TYPE_EXTENSION_INSTALLED = 10,  // Displayed after installing.
 
   // Translation-related bubbles:
   BUBBLE_TYPE_TRANSLATE = 20,  // Displays a request to translate a page.
 
   // Permissions-related bubbles:
   BUBBLE_TYPE_PERMISSION = 30,  // Displays a permission request to the user.
+  BUBBLE_TYPE_CHOOSER_PERMISSION = 31,  // For chooser permissions.
 
   // Upper boundary for metrics.
   BUBBLE_TYPE_MAX,
 };
 
 // Convert from bubble name to ID. The bubble ID will allow collecting the
 // close reason for each bubble type.
 static int GetBubbleId(BubbleReference bubble) {
   BubbleType bubble_type = BUBBLE_TYPE_UNKNOWN;
 
   // Translate from bubble name to enum.
   if (bubble->GetName().compare("MockBubble") == 0)
     bubble_type = BUBBLE_TYPE_MOCK;
   else if (bubble->GetName().compare("ExtensionInstalled") == 0)
     bubble_type = BUBBLE_TYPE_EXTENSION_INSTALLED;
   else if (bubble->GetName().compare("TranslateBubble") == 0)
     bubble_type = BUBBLE_TYPE_TRANSLATE;
   else if (bubble->GetName().compare("PermissionBubble") == 0)
     bubble_type = BUBBLE_TYPE_PERMISSION;
+  else if (bubble->GetName().compare("ChooserBubble") == 0)

[sky, 2015/12/10 00:32:47]

I'm not familiar with this code. Where are the raw strings coming from?

[juncai, 2015/12/10 00:38:38]

https://codereview.chromium.org/1408193003/diff/590001/chrome/browser/ui/webs...
So for the chooser permission bubble, it overrides BubbleDelegate's
std::string GetName(), it can help collecting metrics.

[sky, 2015/12/10 00:59:15]

Problem with strings is it's easy to change the string and not realize you have
a dependency like this. Can't the bubble return the type?

[juncai, 2015/12/10 01:06:54]

Quoting from email from hcarmona@:
"The reason we use a string to identify the bubble, then convert to an enum is
because the enums are specific to the desktop version of chrome, but we want to
keep the bubble manager independent enough to also work on android and iOS in
the future."

+    bubble_type = BUBBLE_TYPE_CHOOSER_PERMISSION;
 
   DCHECK_NE(bubble_type, BUBBLE_TYPE_UNKNOWN);
   DCHECK_NE(bubble_type, BUBBLE_TYPE_MAX);
 
   return bubble_type;
 }
 
 // Log the reason for closing this bubble.
 // Each reason is its own metric. Each histogram call MUST have a runtime
 // constant value passed in for the title.
@@ skipping 88 matching lines @@
 }
 
 void ChromeBubbleManager::ChromeBubbleMetrics::OnBubbleClosed(
     BubbleReference bubble, BubbleCloseReason reason) {
   // Log the amount of time the bubble was visible.
   base::TimeDelta visible_time = bubble->GetVisibleTime();
   UMA_HISTOGRAM_LONG_TIMES("Bubbles.DisplayTime.All", visible_time);
 
   LogBubbleCloseReason(bubble, reason);
 }