Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408183006: [heap] Decrease incremental marking finalization retry limit. (Closed)

Created:
5 years, 1 month ago by Hannes Payer (out of office)
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Decrease incremental marking finalization retry limit. BUG=chromium:548562 LOG=n Committed: https://crrev.com/c689f5759b46506c38c84f404ebd8dc326dcb76f Cr-Commit-Position: refs/heads/master@{#31647}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
5 years, 1 month ago (2015-10-29 08:47:34 UTC) #2
ulan
lgtm
5 years, 1 month ago (2015-10-29 09:30:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408183006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408183006/1
5 years, 1 month ago (2015-10-29 09:40:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 09:42:09 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c689f5759b46506c38c84f404ebd8dc326dcb76f Cr-Commit-Position: refs/heads/master@{#31647}
5 years, 1 month ago (2015-10-29 09:42:47 UTC) #7
Hannes Payer (out of office)
5 years, 1 month ago (2015-10-29 11:44:34 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1428783004/ by hpayer@chromium.org.

The reason for reverting is: crashes on webkit_unit_tests V8-Blink Linux 32.

Powered by Google App Engine
This is Rietveld 408576698