Issue 1408163008: Fix for duplicate priority sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408163008: Fix for duplicate priority sources. (Closed)

Created:
5 years, 1 month ago by scheglov

Modified:
5 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for duplicate priority sources. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/03eed1c3c944d3122a257a95d4e2dcc391f8668e

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	pkg/analysis_server/test/analysis/set_priority_files_test.dart	View		2 chunks	+19 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1408163008/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart File pkg/analysis_server/test/analysis/set_priority_files_test.dart (right): https://codereview.chromium.org/1408163008/diff/1/pkg/analysis_server/test/analysis/set_priority_files_test.dart#newcode41 pkg/analysis_server/test/analysis/set_priority_files_test.dart:41: // wait for analysis to ensure that file ...

5 years, 1 month ago (2015-10-30 00:08:49 UTC) #2

scheglov

5 years, 1 month ago (2015-10-30 00:46:06 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
03eed1c3c944d3122a257a95d4e2dcc391f8668e (presubmit successful).

Expand Messages | Collapse Messages