[es6] Partially implement Reflect.getOwnPropertyDescriptor.

src/property-descriptor.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/property-descriptor.h"
 
 #include "src/bootstrapper.h"
 #include "src/factory.h"
 #include "src/isolate-inl.h"
 #include "src/lookup.h"
@@ skipping 83 matching lines @@
   }
   if ((desc->has_get() || desc->has_set()) &&
       (desc->has_value() || desc->has_writable())) {
     // Bail out to slow path to throw an exception.
     return false;
   }
   return true;
 }
 
 
+static void CreateDataProperty(Isolate* isolate, Handle<JSObject> object,
+                               const char* name, Handle<Object> value) {
+  LookupIterator it(object,
+                    isolate->factory()->NewStringFromAsciiChecked(name));
+  Maybe<bool> result = JSObject::CreateDataProperty(&it, value);
+  CHECK(result.IsJust() && result.FromJust());
+}
+
+
+// ES6 6.2.4.4 "FromPropertyDescriptor"
+Handle<Object> PropertyDescriptor::ToObject(Isolate* isolate) {
+  DCHECK(!(PropertyDescriptor::IsAccessorDescriptor(this) &&
+           PropertyDescriptor::IsDataDescriptor(this)));
+  Handle<JSObject> result =
+      isolate->factory()->NewJSObject(isolate->object_function());
+  if (has_value()) CreateDataProperty(isolate, result, "value", value());

[Jakob Kummerow, 2015/10/29 18:06:02]

Instead of "value", please use isolate->factory()->value_string() here (change
the signature of CreateDataProperty above to take a Handle<String> instead of a
const char*).
You may want to pull out "Factory* factory = isolate->factory()" to make the
code less verbose; it doesn't make a performance difference.

Same for the other property names below.

[neis, 2015/10/30 08:41:30]

Done.

+  if (has_writable()) {
+    CreateDataProperty(isolate, result, "writable",
+                       isolate->factory()->ToBoolean(writable()));
+  }
+  if (has_get()) CreateDataProperty(isolate, result, "get", get());
+  if (has_set()) CreateDataProperty(isolate, result, "set", set());
+  if (has_enumerable()) {
+    CreateDataProperty(isolate, result, "enumerable",
+                       isolate->factory()->ToBoolean(enumerable()));
+  }
+  if (has_configurable()) {
+    CreateDataProperty(isolate, result, "configurable",
+                       isolate->factory()->ToBoolean(configurable()));
+  }
+  return result;
+}
+
+
 // ES6 6.2.4.5
 // Returns false in case of exception.
 // static
 bool PropertyDescriptor::ToPropertyDescriptor(Isolate* isolate,
                                               Handle<Object> obj,
                                               PropertyDescriptor* desc) {
   // 1. ReturnIfAbrupt(Obj).
   // 2. If Type(Obj) is not Object, throw a TypeError exception.
   if (!obj->IsSpecObject()) {
     isolate->Throw(*isolate->factory()->NewTypeError(
@@ skipping 106 matching lines @@
         *isolate->factory()->NewTypeError(MessageTemplate::kUnsupported));
     return false;
   }
   // 23. Return desc.
   return true;
 }
 
 
 }  // namespace internal
 }  // namespace v8