Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1408163003: Move RootIndexMap out of serializer file. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move RootIndexMap out of serializer file. This is in preparation of using it elsewhere. R=bmeurer@chromium.org Committed: https://crrev.com/11cd1f77ae31508ac4b53b595ff7575ccd4e8183 Cr-Commit-Position: refs/heads/master@{#31499}

Patch Set 1 #

Patch Set 2 : add files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -195 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/address-map.h View 1 1 chunk +184 lines, -0 lines 0 comments Download
A src/address-map.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
M src/compiler/code-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/context-measure.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/snapshot/serialize.h View 3 chunks +1 line, -168 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 2 months ago (2015-10-23 07:14:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408163003/20001
5 years, 2 months ago (2015-10-23 07:31:44 UTC) #3
Benedikt Meurer
LGTM
5 years, 2 months ago (2015-10-23 07:42:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-23 08:15:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408163003/20001
5 years, 2 months ago (2015-10-23 08:26:58 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-23 08:28:28 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 08:28:43 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/11cd1f77ae31508ac4b53b595ff7575ccd4e8183
Cr-Commit-Position: refs/heads/master@{#31499}

Powered by Google App Engine
This is Rietveld 408576698