Issue 1408133004: EDK: Remove tracked_objects::Location argument in TestIOThread methods (etc.).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408133004: EDK: Remove tracked_objects::Location argument in TestIOThread methods (etc.). (Closed)

Created:
5 years, 2 months ago by viettrungluu

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: Remove tracked_objects::Location argument in TestIOThread methods (etc.). I've never found the tracking information useful in this code, and the abstraction/wrapper around base::TaskRunner won't have it. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4af4c9b922843cd93f59ec78766c0952fb8d11a1

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -130 lines)			Patch
M	mojo/edk/embedder/embedder_unittest.cc	View	5 chunks	+2 lines, -7 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint_unittest.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	mojo/edk/system/channel_test_base.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	mojo/edk/system/channel_test_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/edk/system/channel_unittest.cc	View	8 chunks	+13 lines, -21 lines	0 comments	Download
M	mojo/edk/system/data_pipe_impl_unittest.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	mojo/edk/system/endpoint_relayer_unittest.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	mojo/edk/system/ipc_support_unittest.cc	View	7 chunks	+7 lines, -12 lines	0 comments	Download
M	mojo/edk/system/message_pipe_test_utils.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	mojo/edk/system/raw_channel_unittest.cc	View	20 chunks	+12 lines, -29 lines	0 comments	Download
M	mojo/edk/system/remote_data_pipe_impl_unittest.cc	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	mojo/edk/system/remote_message_pipe_unittest.cc	View	6 chunks	+6 lines, -14 lines	0 comments	Download
M	mojo/edk/test/test_io_thread.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	mojo/edk/test/test_io_thread.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

5 years, 2 months ago (2015-10-20 05:27:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4af4c9b922843cd93f59ec78766c0952fb8d11a1 (presubmit successful).

Expand Messages | Collapse Messages