Issue 1408123011: Use find_depot_tools.py and vs_toolchain.py from chromium/src/build/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408123011: Use find_depot_tools.py and vs_toolchain.py from chromium/src/build/ (Closed)

Created:
5 years, 1 month ago by Roland McGrath

Modified:
5 years, 1 month ago

Reviewers:
bradnelson

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

More Reviews

Description

Use find_depot_tools.py and vs_toolchain.py from chromium/src/build/ This removes the local versions of the find_depot_tools.py and vs_toolchain.py scripts. Instead just use the chromium/src/build/ versions gotten via DEPS. BUG=512869 TEST= trybots R=bradnelson@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/bedb75a80ce995bc458739846cf0c42df3bcbe6f

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -225 lines)			Patch
M	DEPS	View	1 chunk	+3 lines, -3 lines	0 comments	Download
D	build/find_depot_tools.py	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	build/vs_toolchain.py	View	1 chunk	+0 lines, -173 lines	0 comments	Download
M	tools/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408123011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408123011/1

5 years, 1 month ago (2015-10-27 00:17:55 UTC) #4

commit-bot: I haz the power

5 years, 1 month ago (2015-10-27 00:43:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/bedb75a80...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages