Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 1408123005: Android Webview IPC-based sync compositing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index b6d9dd61e3ab0e887d29df975d2a399a98b34f8e..c47e423c271654dfd1eb4f6ea72e97c951f8b5c2 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -159,7 +159,9 @@
#if defined(OS_ANDROID)
#include <cpu-features.h>
+#include "content/renderer/android/synchronous_compositor_external_begin_frame_source.h"
#include "content/renderer/android/synchronous_compositor_factory.h"
+#include "content/renderer/android/synchronous_compositor_filter.h"
#include "content/renderer/media/android/renderer_demuxer_android.h"
#endif
@@ -860,6 +862,13 @@ void RenderThreadImpl::Shutdown() {
compositor_message_filter_ = NULL;
}
+#if defined(OS_ANDROID)
+ if (sync_compositor_message_filter_.get()) {
+ RemoveFilter(sync_compositor_message_filter_.get());
+ sync_compositor_message_filter_ = NULL;
+ }
+#endif
+
media_thread_.reset();
compositor_thread_.reset();
@@ -1132,9 +1141,17 @@ void RenderThreadImpl::EnsureWebKitInitialized() {
bool enable = !command_line.HasSwitch(switches::kDisableThreadedCompositing);
if (enable) {
#if defined(OS_ANDROID)
- if (SynchronousCompositorFactory* factory =
- SynchronousCompositorFactory::GetInstance())
- compositor_task_runner_ = factory->GetCompositorTaskRunner();
+ SynchronousCompositorFactory* sync_compositor_factory =
+ SynchronousCompositorFactory::GetInstance();
+ bool using_ipc_sync_compositing =
+ base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kIPCSyncCompositing);
+ DCHECK(!sync_compositor_factory || !using_ipc_sync_compositing);
+
+ if (sync_compositor_factory) {
+ compositor_task_runner_ =
+ sync_compositor_factory->GetCompositorTaskRunner();
+ }
#endif
if (!compositor_task_runner_.get()) {
compositor_thread_.reset(new base::Thread("Compositor"));
@@ -1152,9 +1169,14 @@ void RenderThreadImpl::EnsureWebKitInitialized() {
InputHandlerManagerClient* input_handler_manager_client = NULL;
#if defined(OS_ANDROID)
- if (SynchronousCompositorFactory* factory =
- SynchronousCompositorFactory::GetInstance()) {
- input_handler_manager_client = factory->GetInputHandlerManagerClient();
+ if (using_ipc_sync_compositing) {
+ sync_compositor_message_filter_ =
+ new SynchronousCompositorFilter(compositor_task_runner_);
+ AddFilter(sync_compositor_message_filter_.get());
+ input_handler_manager_client = sync_compositor_message_filter_.get();
+ } else if (sync_compositor_factory) {
+ input_handler_manager_client =
+ sync_compositor_factory->GetInputHandlerManagerClient();
}
#endif
if (!input_handler_manager_client) {
@@ -1547,7 +1569,11 @@ RenderThreadImpl::CreateExternalBeginFrameSource(int routing_id) {
#if defined(OS_ANDROID)
if (SynchronousCompositorFactory* factory =
SynchronousCompositorFactory::GetInstance()) {
+ DCHECK(!sync_compositor_message_filter_.get());
return factory->CreateExternalBeginFrameSource(routing_id);
+ } else if (sync_compositor_message_filter_.get()) {
+ return make_scoped_ptr(new SynchronousCompositorExternalBeginFrameSource(
+ routing_id, sync_compositor_message_filter_.get()));
}
#endif
return make_scoped_ptr(new CompositorExternalBeginFrameSource(

Powered by Google App Engine
This is Rietveld 408576698