Android Webview IPC-based sync compositing

content/common/android/sync_compositor_messages.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/output/begin_frame_args.h"
+#include "cc/output/compositor_frame.h"
+#include "cc/resources/returned_resource.h"
+#include "content/common/content_export.h"
+#include "content/common/content_param_traits.h"
+#include "content/common/input/input_event_ack_state.h"
+#include "ipc/ipc_message_macros.h"
+#include "third_party/WebKit/public/web/WebInputEvent.h"
+#include "ui/gfx/geometry/scroll_offset.h"
+
+#ifndef CONTENT_COMMON_ANDROID_SYNC_COMPOSITOR_MESSAGES_H_
+#define CONTENT_COMMON_ANDROID_SYNC_COMPOSITOR_MESSAGES_H_
+
+namespace content {
+
+struct CommonBrowserParams {

[no sievers, 2015/10/29 01:37:00]

nit: this name seems a bit generic

Do all these structs actually have to be in here? Or can they maybe be inside
SynchronousCompositor or somewhere?
also would make the ifdef-boundaries less odd

[boliu, 2015/10/29 04:24:43]

They have to be in common because both renderer and browser sides need them.
They could be a in a different file though if preferred. But I think the general
pattern is put these at the top of the messages file (unless they get used in
places other than these IPCs)

Yeah, these kind of sound generic for content namespace. Prepended
SyncCompositor to them.

+  CommonBrowserParams();
+  CommonBrowserParams(size_t bytes_limit,
+                      const gfx::ScrollOffset& root_scroll_offset);
+  ~CommonBrowserParams();
+
+  size_t bytes_limit;
+  cc::ReturnedResourceArray resources;
+  gfx::ScrollOffset root_scroll_offset;
+};
+
+struct DemandDrawHwParams {
+  DemandDrawHwParams();
+  DemandDrawHwParams(const gfx::Size& surface_size,
+                     const gfx::Transform& transform,
+                     const gfx::Rect& viewport,
+                     const gfx::Rect& clip,
+                     const gfx::Rect& viewport_rect_for_tile_priority,
+                     const gfx::Transform& transform_for_tile_priority);
+  ~DemandDrawHwParams();
+
+  gfx::Size surface_size;
+  gfx::Transform transform;
+  gfx::Rect viewport;
+  gfx::Rect clip;
+  gfx::Rect viewport_rect_for_tile_priority;
+  gfx::Transform transform_for_tile_priority;
+};
+
+struct CommonRendererParams {
+  CommonRendererParams();
+  CommonRendererParams(unsigned int version,
+                       const gfx::ScrollOffset& total_scroll_offset,
+                       const gfx::ScrollOffset& max_scroll_offset,
+                       const gfx::SizeF& scrollable_size,
+                       float page_scale_factor,
+                       float min_page_scale_factor,
+                       float max_page_scale_factor,
+                       bool need_animate_scroll,
+                       bool need_invalidate,
+                       bool need_begin_frame,
+                       bool did_activate_pending_tree);
+  ~CommonRendererParams();
+
+  unsigned int version;
+  gfx::ScrollOffset total_scroll_offset;
+  gfx::ScrollOffset max_scroll_offset;
+  gfx::SizeF scrollable_size;
+  float page_scale_factor;
+  float min_page_scale_factor;
+  float max_page_scale_factor;
+  bool need_animate_scroll;
+  bool need_invalidate;
+  bool need_begin_frame;
+  bool did_activate_pending_tree;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_COMMON_ANDROID_SYNC_COMPOSITOR_MESSAGES_H_
+
+// Multiply-included message file, hence no include guard.
+
+#undef IPC_MESSAGE_EXPORT
+#define IPC_MESSAGE_EXPORT CONTENT_EXPORT
+#define IPC_MESSAGE_START SyncCompositorMsgStart
+
+IPC_STRUCT_TRAITS_BEGIN(content::CommonBrowserParams)
+  IPC_STRUCT_TRAITS_MEMBER(bytes_limit)
+  IPC_STRUCT_TRAITS_MEMBER(resources)
+  IPC_STRUCT_TRAITS_MEMBER(root_scroll_offset)
+IPC_STRUCT_TRAITS_END()
+
+IPC_STRUCT_TRAITS_BEGIN(content::DemandDrawHwParams)
+  IPC_STRUCT_TRAITS_MEMBER(surface_size)
+  IPC_STRUCT_TRAITS_MEMBER(transform)
+  IPC_STRUCT_TRAITS_MEMBER(viewport)
+  IPC_STRUCT_TRAITS_MEMBER(clip)
+  IPC_STRUCT_TRAITS_MEMBER(viewport_rect_for_tile_priority)
+  IPC_STRUCT_TRAITS_MEMBER(transform_for_tile_priority)
+IPC_STRUCT_TRAITS_END()
+
+IPC_STRUCT_TRAITS_BEGIN(content::CommonRendererParams)
+  IPC_STRUCT_TRAITS_MEMBER(version)
+  IPC_STRUCT_TRAITS_MEMBER(total_scroll_offset)
+  IPC_STRUCT_TRAITS_MEMBER(max_scroll_offset)
+  IPC_STRUCT_TRAITS_MEMBER(scrollable_size)
+  IPC_STRUCT_TRAITS_MEMBER(page_scale_factor)
+  IPC_STRUCT_TRAITS_MEMBER(min_page_scale_factor)
+  IPC_STRUCT_TRAITS_MEMBER(max_page_scale_factor)
+  IPC_STRUCT_TRAITS_MEMBER(need_animate_scroll)
+  IPC_STRUCT_TRAITS_MEMBER(need_invalidate)
+  IPC_STRUCT_TRAITS_MEMBER(need_begin_frame)
+  IPC_STRUCT_TRAITS_MEMBER(did_activate_pending_tree)
+IPC_STRUCT_TRAITS_END()
+
+IPC_SYNC_MESSAGE_ROUTED2_2(SyncCompositorMsg_HandleInputEvent,
+                           content::CommonBrowserParams,
+                           IPC::WebInputEventPointer,
+                           content::CommonRendererParams,
+                           content::InputEventAckState);
+
+IPC_SYNC_MESSAGE_ROUTED2_1(SyncCompositorMsg_BeginFrame,
+                           content::CommonBrowserParams,
+                           cc::BeginFrameArgs,
+                           content::CommonRendererParams);
+
+IPC_SYNC_MESSAGE_ROUTED2_1(SyncCompositorMsg_ComputeScroll,
+                           content::CommonBrowserParams,
+                           base::TimeTicks,
+                           content::CommonRendererParams);
+
+IPC_SYNC_MESSAGE_ROUTED2_2(SyncCompositorMsg_DemandDrawHw,
+                           content::CommonBrowserParams,
+                           content::DemandDrawHwParams,
+                           content::CommonRendererParams,
+                           cc::CompositorFrame);
+
+IPC_MESSAGE_ROUTED1(SyncCompositorHostMsg_UpdateState,
+                    content::CommonRendererParams);