components/sync_driver/device_info_sync_service.h - Issue 1408123003: [Sync] Initial USS service implementation for DeviceInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_sync_service.h

Issue 1408123003: [Sync] Initial USS service implementation for DeviceInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added some stub imaginary methods for the ModelTypeService interface. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync_driver/device_info_service.h ('K') | « components/sync_driver/device_info_service_unittest.cc ('k') | components/sync_driver/device_info_sync_service.cc » ('j') | components/sync_driver/local_device_info_provider_mock.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_sync_service.h

diff --git a/components/sync_driver/device_info_sync_service.h b/components/sync_driver/device_info_sync_service.h

index aadeff96e3cf94e8c6020cd3648c72efd13a9368..2f1e89a2d7f0a7b6fcb1b9f68ba04bc213501372 100644

--- a/components/sync_driver/device_info_sync_service.h

+++ b/components/sync_driver/device_info_sync_service.h

@@ -8,6 +8,8 @@

#include <map>

#include <string>

+#include "base/memory/scoped_ptr.h"

+#include "base/memory/scoped_vector.h"

#include "base/observer_list.h"

#include "components/sync_driver/device_info_tracker.h"

#include "sync/api/sync_change_processor.h"

@@ -60,7 +62,7 @@ class DeviceInfoSyncService : public syncer::SyncableService,

const sync_pb::EntitySpecifics& entity);

// Allocate new DeviceInfo from SyncData.

- static DeviceInfo* CreateDeviceInfo(const syncer::SyncData sync_data);

+ static DeviceInfo* CreateDeviceInfo(const syncer::SyncData& sync_data);

// Store SyncData in the cache.

void StoreSyncData(const std::string& client_id,

const syncer::SyncData& sync_data);